Resolving issue when an alternate BUNDLE_PATH is used#1
Open
Resolving issue when an alternate BUNDLE_PATH is used#1
Conversation
…ec instead of stopping on 2 tries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue description:
If BUNDLE_PATH in .bundle/config is set to some other directory, for example
or if bundle install was previous executed with --path parameter
Warbler will not able to detect the bundler's gemspec location correctly (from the bundler's load_from attribute). As the result, a corrupted bundle gem will be included into the war file and we will see a load error when attempting to run this war file inside a servlet container.
Analysis:
The existing code seems to have some logic that tries to detect the location of the bundler.gemspec based on the bundler's load_from attribute. However, the implementation quits after looking up parent folder two times and silently continue without raising any error.
Proposed Change:
Instead of just lookup parent folders for 2 levels, the fix keep searching for the bundler gemspec until it hits the root dir. If bundler gemspec cannot be found, it will raise an error message and exit the build process.