initial operator message types#454
Open
vladimir-ea wants to merge 1 commit into
Open
Conversation
vladimir-ea
force-pushed
the
ve/operator_types
branch
from
91660de to
67e92b4
Compare
vladimir-ea
commented
Jul 14, 2026
| #[derive(Debug, Decode, Encode, Hash)] | ||
| pub struct Demotion { | ||
| /// Originating operator, utf8 bytes | ||
| operator_id: Vec<u8>, |
Contributor
Author
There was a problem hiding this comment.
this id may be unnecessary if we do straight-forward pubsub on p2p (aka floodsub) rather than gossip, since then the originator id is the sending peer id.
gd-0
reviewed
Jul 14, 2026
| #[derive(Debug, Decode, Encode, Hash)] | ||
| pub struct Demotion { | ||
| /// Originating operator, utf8 bytes | ||
| operator_id: Vec<u8>, |
Collaborator
There was a problem hiding this comment.
Lets just make this fixed size?
Comment on lines
+14
to
+16
| let mut hasher = DefaultHasher::new(); | ||
| self.hash(&mut hasher); | ||
| (TYPE as u64) << 56 | hasher.finish() >> 8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
operator message types for use on p2p
the
operator_idin the messages is justVec<u8>- we should decide what identifiers we want use:-?
i will add the p2p impl next.