Run worker with django autoreloader by default#16
Open
Majsvaffla wants to merge 2 commits intogavinwahl:masterfrom
Open
Run worker with django autoreloader by default#16Majsvaffla wants to merge 2 commits intogavinwahl:masterfrom
Majsvaffla wants to merge 2 commits intogavinwahl:masterfrom
Conversation
f64e846 to
bd6819a
Compare
Owner
|
Good idea, but I don't think it should be the default |
Author
Fair enough :) I've also been thinking of adding support for watchfiles. Having more reloader options also promotes not having a default I think. |
Owner
|
If autoreloading is already in Django, what's the point of using something else? |
Author
|
It's a bit hacky to hook into the Django autoreloader since it's not really designed for that. Watchfiles also performs better than the reloader mechanism built into Django from my experience. |
bd6819a to
13fcebb
Compare
Author
|
I've changed it to opt-in as you proposed 🙂 Use Regarding watchfiles, I guess this would use watchfiles implicitly if the django project were using django-watchfiles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it would be a neat addition to support auto-reload like
django-admin runserverdoes. That is usually what you want while developing.