Raise exception if root link is missing in URDF#28
Open
lorycontixd wants to merge 2 commits intogbionics:mainfrom
Open
Raise exception if root link is missing in URDF#28lorycontixd wants to merge 2 commits intogbionics:mainfrom
lorycontixd wants to merge 2 commits intogbionics:mainfrom
Conversation
Author
|
Resolving lines: has_root_link = "root" in [l.attrib['name'] for l in root.findall(".//link")]
if not has_root_link:
raise ValueError("The URDF file must have a link named 'root'") |
Author
|
Reference the second commit, not the first one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When no link named 'root' is present in the urdf loaded by mujoco, the following exception is automatically raised:
I think this error is missleading as it points towards a missing joint instead of a missing root link.
Therefore, I think it'd be best to search for a link named
rootas the model loads, and raise a custom exception if this link is not found.