Skip to content

Conversation

@gburd
Copy link
Owner

@gburd gburd commented Jan 30, 2026

Testing PRMX email bridge functionality

For readability. It was a slight modularity violation to have fields
in PGShmemHeader that were only used by the allocator code in
shmem.c. And it was inconsistent that ShmemLock was nevertheless not
stored there. Moving all the allocator-related fields to a separate
struct makes it more consistent and modular, and removes the need to
allocate and pass ShmemLock separately via BackendParameters.

Merge InitShmemAccess() and InitShmemAllocation() into a single
function that initializes the struct when called from postmaster, and
when called from backends in EXEC_BACKEND mode, re-establishes the
global variables. That's similar to all the *ShmemInit() functions
that we have.

@gburd gburd force-pushed the test-prmx-feature branch 4 times, most recently from a7439ed to a3f04a4 Compare January 31, 2026 16:45
@gburd
Copy link
Owner Author

gburd commented Jan 31, 2026

Submitted as pull.19.postgres.1769878402958.gregburd@amazon.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gburd/postgres/ pr-19/gburd/test-prmx-feature-v1

To fetch this version to local tag pr-19/gburd/test-prmx-feature-v1:

git fetch --no-tags https://github.com/gburd/postgres/ tag pr-19/gburd/test-prmx-feature-v1

This is a commit that is designed to test the PRMX integration between
GitHub and the PostgreSQL Hacker's email list.  It's a fork of the
GitGitGadget code used by the Git team for the same purpose, thanks
open source friends!  We appreciate what you've built and we're happy
to be able to reuse it.

For readability. It was a slight modularity violation to have fields in
PGShmemHeader that were only used by the allocator code in shmem.c. And
it was inconsistent that ShmemLock was nevertheless not stored there.
Moving all the allocator-related fields to a separate struct makes it
more consistent and modular, and removes the need to allocate and pass
ShmemLock separately via BackendParameters.

Merge InitShmemAccess() and InitShmemAllocation() into a single
function that initializes the struct when called from postmaster, and
when called from backends in EXEC_BACKEND mode, re-establishes the
global variables. That's similar to all the *ShmemInit() functions that
we have.

Reported-by: Greg Burd <greg@burd.me>
Diagnosed-by: Greg Burd <greg@burd.me>
Reviewed-by: Greg Burd <greg@burd.me>
Author: Greg Burd <greg@burd.me>
Signed-off-by: Greg Burd <greg@burd.me>
Discussion: https://postgr.es/m/db6fdb35a8665ad3c18be01181d44b31@postgrespro.ru
Backpatch-through: 14
Signed-off-by: Greg Burd <greg@burd.me>
@gburd gburd force-pushed the test-prmx-feature branch from a3f04a4 to 0ab2d61 Compare January 31, 2026 17:17
@gburd
Copy link
Owner Author

gburd commented Jan 31, 2026

Submitted as pull.19.v2.postgres.1769880438607.gregburd@amazon.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gburd/postgres/ pr-19/gburd/test-prmx-feature-v2

To fetch this version to local tag pr-19/gburd/test-prmx-feature-v2:

git fetch --no-tags https://github.com/gburd/postgres/ tag pr-19/gburd/test-prmx-feature-v2

@gburd gburd force-pushed the test-prmx-feature branch 3 times, most recently from 3aa44c3 to 175c4bc Compare January 31, 2026 17:52
This is yet another change to test GitGitGadget for PG use.  I have no
idea what this will do, but I do appreciate HISTORY.

I'm not sure how much more I have to write to pass the test for "long
enough", so I'll just write more until I get bored.

I'm bored.
@gburd gburd force-pushed the test-prmx-feature branch from 175c4bc to 2358129 Compare January 31, 2026 17:55
@gburd
Copy link
Owner Author

gburd commented Jan 31, 2026

/submit

@gburd
Copy link
Owner Author

gburd commented Jan 31, 2026

Submitted as pull.19.v3.postgres.1769883484377.gregburd@amazon.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gburd/postgres/ pr-19/gburd/test-prmx-feature-v3

To fetch this version to local tag pr-19/gburd/test-prmx-feature-v3:

git fetch --no-tags https://github.com/gburd/postgres/ tag pr-19/gburd/test-prmx-feature-v3

@gburd
Copy link
Owner Author

gburd commented Feb 2, 2026

There is an issue in commit daccdd2:
test: v4 iteration test

  • Commit checks stopped - the message is too short

This is a test commit to verify that the v4 iteration works correctly
with the updated subject line format (no 0/N) and proper footer links
including Published-As, Fetch-It-Via, Pull-Request, and Range-diff.
@gburd gburd force-pushed the test-prmx-feature branch from daccdd2 to 6b603e7 Compare February 2, 2026 12:45
@gburd
Copy link
Owner Author

gburd commented Feb 2, 2026

Submitted as pull.19.v4.postgres.1770036351814.gregburd@amazon.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gburd/postgres/ pr-19/gburd/test-prmx-feature-v4

To fetch this version to local tag pr-19/gburd/test-prmx-feature-v4:

git fetch --no-tags https://github.com/gburd/postgres/ tag pr-19/gburd/test-prmx-feature-v4

Comment on lines +6 to +7

and that's the way it was... walter cronkite
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, but why?

Comment on lines +22 to +25

test. test.
test...ing...the test.
test v4
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pointless, duh.

Copy link
Owner Author

@gburd gburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take a closer look at what you've done...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants