-
Notifications
You must be signed in to change notification settings - Fork 0
Test PRMX integration #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
a7439ed to
a3f04a4
Compare
|
Submitted as pull.19.postgres.1769878402958.gregburd@amazon.com To fetch this version into To fetch this version to local tag |
This is a commit that is designed to test the PRMX integration between GitHub and the PostgreSQL Hacker's email list. It's a fork of the GitGitGadget code used by the Git team for the same purpose, thanks open source friends! We appreciate what you've built and we're happy to be able to reuse it. For readability. It was a slight modularity violation to have fields in PGShmemHeader that were only used by the allocator code in shmem.c. And it was inconsistent that ShmemLock was nevertheless not stored there. Moving all the allocator-related fields to a separate struct makes it more consistent and modular, and removes the need to allocate and pass ShmemLock separately via BackendParameters. Merge InitShmemAccess() and InitShmemAllocation() into a single function that initializes the struct when called from postmaster, and when called from backends in EXEC_BACKEND mode, re-establishes the global variables. That's similar to all the *ShmemInit() functions that we have. Reported-by: Greg Burd <greg@burd.me> Diagnosed-by: Greg Burd <greg@burd.me> Reviewed-by: Greg Burd <greg@burd.me> Author: Greg Burd <greg@burd.me> Signed-off-by: Greg Burd <greg@burd.me> Discussion: https://postgr.es/m/db6fdb35a8665ad3c18be01181d44b31@postgrespro.ru Backpatch-through: 14 Signed-off-by: Greg Burd <greg@burd.me>
a3f04a4 to
0ab2d61
Compare
|
Submitted as pull.19.v2.postgres.1769880438607.gregburd@amazon.com To fetch this version into To fetch this version to local tag |
3aa44c3 to
175c4bc
Compare
This is yet another change to test GitGitGadget for PG use. I have no idea what this will do, but I do appreciate HISTORY. I'm not sure how much more I have to write to pass the test for "long enough", so I'll just write more until I get bored. I'm bored.
175c4bc to
2358129
Compare
|
/submit |
|
Submitted as pull.19.v3.postgres.1769883484377.gregburd@amazon.com To fetch this version into To fetch this version to local tag |
|
There is an issue in commit daccdd2:
|
This is a test commit to verify that the v4 iteration works correctly with the updated subject line format (no 0/N) and proper footer links including Published-As, Fetch-It-Via, Pull-Request, and Range-diff.
daccdd2 to
6b603e7
Compare
|
Submitted as pull.19.v4.postgres.1770036351814.gregburd@amazon.com To fetch this version into To fetch this version to local tag |
|
|
||
| and that's the way it was... walter cronkite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, but why?
|
|
||
| test. test. | ||
| test...ing...the test. | ||
| test v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pointless, duh.
gburd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's take a closer look at what you've done...
Testing PRMX email bridge functionality
For readability. It was a slight modularity violation to have fields
in PGShmemHeader that were only used by the allocator code in
shmem.c. And it was inconsistent that ShmemLock was nevertheless not
stored there. Moving all the allocator-related fields to a separate
struct makes it more consistent and modular, and removes the need to
allocate and pass ShmemLock separately via BackendParameters.
Merge InitShmemAccess() and InitShmemAllocation() into a single
function that initializes the struct when called from postmaster, and
when called from backends in EXEC_BACKEND mode, re-establishes the
global variables. That's similar to all the *ShmemInit() functions
that we have.