feat(ui): add light and dark mode with theme toggle#27
Closed
Conversation
Add @vitest/coverage-v8 with 90% thresholds on statements, branches, functions, and lines. Coverage enforcement runs in both pre-commit hooks and CI, with coverage-final.json uploaded as a GitHub Actions artifact. Added 21 new tests (34 -> 55) to achieve 100% coverage across all metrics for main.ts, service_worker.ts, and utils.ts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jared Scott <jared.scott@variable.team>
Add a coverage-report workflow that triggers after CI completes on PRs. It downloads coverage artifacts from both the PR and master branches, compares them, and posts a markdown summary as a PR comment showing overall coverage delta and per-file coverage for changed files. Changes: - ci.yml: trigger on push to master, upload coverage-main artifact - coverage-report.yml: new workflow_run-triggered reporter - scripts/coverage-report.cjs: coverage comparison and report generation - src/coverage-report.spec.ts: 29 tests for the report script Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jared Scott <jared.scott@variable.team>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jared Scott <jared.scott@variable.team>
- Checkout default branch instead of PR head to prevent untrusted code execution in a privileged workflow_run context - Move attacker-controllable values (head_branch, head_owner) to env variables to prevent shell injection via crafted branch names - Replace tj-actions/changed-files with gh pr diff API call to avoid needing PR code checkout Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jared Scott <jared.scott@variable.team>
Move steps.pr.outputs.number and steps.changed.outputs.files from
direct ${{ }} interpolation in run: blocks to env: variables,
preventing potential shell injection via attacker-controlled values.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Jared Scott <jared.scott@variable.team>
Add code coverage tracking and enforce 90% minimum
Signed-off-by: Jared Scott <jared.scott@variable.team> # Conflicts: # pnpm-lock.yaml
Feature/build updates
Add system-preference-aware theming with a manual toggle button that persists the user choice to chrome.storage.local. Uses a warm sepia/paper palette for light mode to reduce eye strain. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Jared Scott <jared.scott@variable.team>
Coverage ReportSummary
Changed Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
Feature
What this PR does / why we need it:
Adds light and dark mode support to the Write Wall extension:
prefers-color-scheme) with a CSS-only fallback to prevent FOUCchrome.storage.local(per-device, not synced)Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
#f0ebe3,#e6e0d6) instead of cool grays for easier readingthemekey inchrome.storage.local(alongside existingcursorkey)color-scheme: light darkadded to#count-modeselect for native widget renderingDoes this PR introduce a user-facing change?:
Yes. Users can now toggle between light and dark mode via a button in the top-right corner. The extension respects the system color scheme preference by default.