Merged
Conversation
queueRAM
approved these changes
Feb 28, 2026
Contributor
queueRAM
left a comment
queueRAM
left a comment
There was a problem hiding this comment.
Looks pretty good, just a couple minor comments
| #include <uv_matrix.h> | ||
| #include <uv_sched.h> | ||
|
|
||
| #define WORLD_MODEL_ID 0xFFFF // used to indicate a model that's not bound to a level? |
Contributor
There was a problem hiding this comment.
Not sure if related, but code in A6000.c considers model id 0xFFFF invalid for its path purposes. I think your name choice makes sense, but I just wonder what it means there.
if (arg1->modelId == 0xFFFF) {
_uvDebugPrintf("uvPathPoseLine: Path has an invalid Model ID!\n");
Contributor
Author
There was a problem hiding this comment.
I suppose something related to "world models" not being.. pathable? or something
Bl00D4NGEL
added a commit
to Bl00D4NGEL/Pilotwings64Decomp
that referenced
this pull request
Mar 3, 2026
* match: func_803464A0 * rename app/level_objects to app/task, rename app/code_CB7C0 to app/target * match the rest of targets.c * match: app/code_C9B60 func_80342630..func_80343294 * match: rest of app/code_C9B60 * misc splat fixes * misc changes * fix build * misc documentation * refac: replace Unk8037DCA0_Unk4C with Unk8037F098
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matches all of app/code_CB7C0.c
matches all of app/code_CD9D0.c
rename app/code_CB7C0.c to app/targets.c
rename app/level_objects.c to app/task.c