Open
Conversation
…(e.g. if you run `wp help`).
…batch.php`. Have made `$items` public and adjusted `class-wp-cli.php` accordingly.
Contributor
Author
|
I've added the subcommands I mentioned in my original message. Running
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the new PR, I couldn't contribute to the original PR and wanted to contribute in a way that provided a mergeable update.
I've taken a look at BramDriesen's work in #24 but ran in to a couple of issues.
wp batch-processing {enter_your_batch_id}get_all_items()doesn't seem to exist in/includes/class-batch.php. I have made$itemspublic and adjustedclass-wp-cli.phpaccordingly. (commit)I've opted for making
$itemspublic instead of adding the missingget_all_items()function, I wasn't sure if this was missing from the original PR or was removed from the main plugin at some point. Making the property public seemed to be a low risk option with minimal code changes.I believe this PR is mergeable, but having used it some QoL additions would be to include a command to: