a typing test script#30
Open
linuxdotexe wants to merge 2 commits intogdsc-gvp:mainfrom
linuxdotexe:main
Open
Conversation
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
himabindu-run
requested changes
Oct 25, 2021
Member
himabindu-run
left a comment
There was a problem hiding this comment.
Hi @linuxdotexe
I have a few concerns regarding your script,
- It's terminating while typing when we "Enter" and giving the result in WPM(Even if type one word and
enterit says 1wpm. - It's not handling wrong spellings, which is okay but at least indicated that something is wrong in some way.
P.S: Good work with the documentation! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
A typing test script
Closes: a CLI typing test #28
Describe the changes you've made
I made a typing test script and added a
README.mdfile explaining the code.Type of change
What sort of change have you made: