Skip to content

refactor(calendar): moving validation logic outside of service - implements #313#316

Open
galuszkak wants to merge 1 commit intogemini-cli-extensions:mainfrom
galuszkak:refactor-calendar
Open

refactor(calendar): moving validation logic outside of service - implements #313#316
galuszkak wants to merge 1 commit intogemini-cli-extensions:mainfrom
galuszkak:refactor-calendar

Conversation

@galuszkak
Copy link
Copy Markdown
Contributor

@galuszkak galuszkak commented Apr 1, 2026

First stab at this problem - did test it locally at mostly got good results. This should try solve #313

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Google Calendar service to use the patch method for event updates, enabling partial updates and preserving unspecified fields. It introduces a centralized validation module, CalendarValidation.ts, which includes a new requirement that all-day workingLocation events must span exactly one day. Additionally, the update logic now supports clearing attachments by passing an empty array. Documentation and tests have been updated to reflect these changes. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant