refactor(calendar): moving validation logic outside of service - implements #313#316
Open
galuszkak wants to merge 1 commit intogemini-cli-extensions:mainfrom
Open
refactor(calendar): moving validation logic outside of service - implements #313#316galuszkak wants to merge 1 commit intogemini-cli-extensions:mainfrom
galuszkak wants to merge 1 commit intogemini-cli-extensions:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Google Calendar service to use the patch method for event updates, enabling partial updates and preserving unspecified fields. It introduces a centralized validation module, CalendarValidation.ts, which includes a new requirement that all-day workingLocation events must span exactly one day. Additionally, the update logic now supports clearing attachments by passing an empty array. Documentation and tests have been updated to reflect these changes. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First stab at this problem - did test it locally at mostly got good results. This should try solve #313