Move Chrome extension from spike/ to packages/chrome-extension - #1526
Merged
Conversation
It's the real client-side half of a shipped feature (the dashboard's claude.ai bridge, packages/the-framework/src/dashboard/bridge-*), not experimental spike work, so it belongs alongside the other packages. Still deliberately has no package.json of its own: pnpm/turbo skip directories without one, so it stays outside the build/test/typecheck pipeline exactly as before. check.mjs's jsdom resolution now points at ../framework-dashboard (one level up instead of two) to match its new location; verified `node --experimental-vm-modules check.mjs` still passes all 14 cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spike/cc-web-extension→packages/chrome-extension. It's the real client-side half of a shipped feature (the dashboard's claude.ai bridge —packages/the-framework/src/dashboard/bridge-store.ts,bridge-endpoints.ts), not experimental spike work, so it belongs alongside the other packages rather than underspike/.package.jsonof its own — pnpm/turbo silently skippackages/*entries without one (verified:pnpm -r list --depth -1shows the same 5 named packages before and after), so it stays outside the build/test/typecheck pipeline exactly as before the move.check.mjs's jsdom resolution path was updated from../../packages/framework-dashboardto../framework-dashboard(one level up instead of two, since it's now a sibling offramework-dashboardunderpackages/instead of two levels away underspike/), and its comment updated to match.Verification
pnpm install— workspace scope unchanged (still resolves the same 5 packages), no errorspnpm typecheck— all 8 tasks pass (full cache hit — nothing in the build graph touches this directory)node --experimental-vm-modules check.mjsfrom the new location — all 14 cases passTest plan
pnpm installpnpm typechecknode --experimental-vm-modules check.mjs(14/14 pass)spike/cc-web-extensionpath — none outside historical CHANGELOG/ticket textGenerated by Claude Code