Bump @cetusprotocol/aggregator-sdk to 1.4.6#128
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the core Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the @cetusprotocol/aggregator-sdk to version 1.4.6, which in turn triggers a significant upgrade of various underlying dependencies, including a major version bump for @mysten/sui and related cryptographic libraries. A critical issue has been identified regarding a dependency conflict with @mysten/sui, where the updated aggregator-sdk requires @mysten/sui@2.9.1, while other parts of the application (specifically @gemwallet/swapper and @mayanfinance/swap-sdk) still depend on @mysten/sui@1.45.2. This version mismatch is problematic and could lead to runtime errors due to incompatible types, especially given the breaking changes between major versions of @mysten/sui. Additionally, the new @mysten/sui@2.9.1 dependency raises the minimum Node.js requirement to >= 22 from >= 18, which needs to be considered for the project's environment and deployment. A comprehensive dependency upgrade across all packages relying on @mysten/sui is necessary to resolve these conflicts.
Add @mysten/sui-v2 pnpm alias pointing to v2.9.1 so we can create a SuiJsonRpcClient for the AggregatorClient. This fixes the "Invalid Sui address" error from passing a v1 SuiClient to the v2-based SDK. Keeps @mysten/sui v1 for Mayan and other Sui code paths.
- Upgrade @mysten/sui from v1.45.2 to v2.9.1 - Switch mayan/sui.ts and chain/sui/tx_builder.ts to v2 - Replace concrete SuiClient/Transaction types in tx_builder with duck-typed interfaces compatible with both v1 and v2
241e673 to
e3ba8a6
Compare
Summary
@cetusprotocol/aggregator-sdkfrom 1.4.5 to 1.4.6Test plan
pnpm buildpassespnpm testpasses (all 67 tests, including cetus bn_replacer tests)