Skip to content

Bump @cetusprotocol/aggregator-sdk to 1.4.6#128

Merged
0xh3rman merged 3 commits intomainfrom
chore/bump-cetus-aggregator-sdk-1.4.6
Mar 25, 2026
Merged

Bump @cetusprotocol/aggregator-sdk to 1.4.6#128
0xh3rman merged 3 commits intomainfrom
chore/bump-cetus-aggregator-sdk-1.4.6

Conversation

@0xh3rman
Copy link
Collaborator

Summary

  • Force update @cetusprotocol/aggregator-sdk from 1.4.5 to 1.4.6

Test plan

  • pnpm build passes
  • pnpm test passes (all 67 tests, including cetus bn_replacer tests)

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the core @cetusprotocol/aggregator-sdk to its latest patch version, 1.4.6. This update ensures that the project benefits from the most recent fixes and minor enhancements within the aggregator SDK. The change necessitated a comprehensive regeneration of the pnpm-lock.yaml file, leading to a cascade of dependency updates across various cryptographic and blockchain-related libraries, streamlining the project's dependency graph and incorporating newer versions of several key packages.

Highlights

  • SDK Version Bump: The @cetusprotocol/aggregator-sdk dependency has been updated from version 1.4.5 to 1.4.6 in packages/swapper/package.json.
  • Dependency Tree Updates: The pnpm-lock.yaml file has been extensively updated to reflect the new SDK version and its transitive dependencies, including updates to @mysten, @noble, @scure, and graphql packages, as well as the replacement of Pyth Network's price service client.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @cetusprotocol/aggregator-sdk to version 1.4.6, which in turn triggers a significant upgrade of various underlying dependencies, including a major version bump for @mysten/sui and related cryptographic libraries. A critical issue has been identified regarding a dependency conflict with @mysten/sui, where the updated aggregator-sdk requires @mysten/sui@2.9.1, while other parts of the application (specifically @gemwallet/swapper and @mayanfinance/swap-sdk) still depend on @mysten/sui@1.45.2. This version mismatch is problematic and could lead to runtime errors due to incompatible types, especially given the breaking changes between major versions of @mysten/sui. Additionally, the new @mysten/sui@2.9.1 dependency raises the minimum Node.js requirement to >= 22 from >= 18, which needs to be considered for the project's environment and deployment. A comprehensive dependency upgrade across all packages relying on @mysten/sui is necessary to resolve these conflicts.

Add @mysten/sui-v2 pnpm alias pointing to v2.9.1 so we can create
a SuiJsonRpcClient for the AggregatorClient. This fixes the "Invalid
Sui address" error from passing a v1 SuiClient to the v2-based SDK.

Keeps @mysten/sui v1 for Mayan and other Sui code paths.
- Upgrade @mysten/sui from v1.45.2 to v2.9.1
- Switch mayan/sui.ts and chain/sui/tx_builder.ts to v2
- Replace concrete SuiClient/Transaction types in tx_builder with
  duck-typed interfaces compatible with both v1 and v2
@0xh3rman 0xh3rman force-pushed the chore/bump-cetus-aggregator-sdk-1.4.6 branch from 241e673 to e3ba8a6 Compare March 25, 2026 03:00
@0xh3rman 0xh3rman merged commit cdea69a into main Mar 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant