Conversation
|
Review changes with Changed Files
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the system's capabilities by re-enabling and enhancing support for HIP3, allowing for seamless integration and aggregation of data from multiple perpetual decentralized exchanges. It introduces new data structures to represent DEXs, refactors the core client to interact with these multiple sources, and implements robust logic to combine diverse data streams into a single, comprehensive view for users. This change broadens the scope of supported trading platforms and improves data consistency. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for multiple perpetual DEXs (HIP3), which is a significant feature. The changes are extensive, touching models, the RPC client, and provider logic to fetch and aggregate data from multiple sources. The implementation appears solid and is accompanied by a good set of unit and integration tests. I have a couple of suggestions to improve code style and use more idiomatic Rust, but overall this is a great contribution.
|
@gemcoder21 I've opened a new pull request, #1012, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@gemcoder21 I've opened a new pull request, #1013, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@gemcoder21 I've opened a new pull request, #1014, to work on those changes. Once the pull request is ready, I'll request review from you. |
0xh3rman
force-pushed
the
codex/hip-3-perps
branch
from
9d722ed to
ad5fe3e
Compare
0xh3rman
force-pushed
the
codex/hip-3-perps
branch
3 times, most recently
from
30214da to
b4ffcd0
Compare
- Fan out perpetual API calls across active builder dexes via `for_each_dex` helper - Add `PerpDex` model and `perpDexs` RPC endpoint - Map HIP-3 asset indices with offset encoding (100k + dex_index * 10k + meta_index) - Format display names as `SYMBOL (dex)` for builder dex assets - Add `only_isolated` to `Perpetual` and `margin_type` to `PerpetualConfirmData` - Use margin type from confirm data in signer instead of hardcoded cross margin - Merge positions, portfolios, and account summaries across dexes - Extract HIP-3 specific logic into `hip3_mapper` module - Extract `with_dex` helper to deduplicate RPC client dex injection - Add `UniverseAsset::mock()` and `AssetMetadata::mock()` to testkit - Make `ReferrerState.data` optional for `needToCreateCode` stage
0xh3rman
force-pushed
the
codex/hip-3-perps
branch
from
b4ffcd0 to
6d912c3
Compare
0xh3rman
force-pushed
the
codex/hip-3-perps
branch
from
435eab6 to
6674190
Compare
- Collapse _with_dex method pairs into single methods with Option<&str> dex param - Add InfoPayload struct with serde skip_serializing_if for clean request building - Add UpdateLeverage::from_margin_type() with unit tests for is_cross - Use from_margin_type in signer instead of inline comparison
0xh3rman
force-pushed
the
codex/hip-3-perps
branch
from
6674190 to
8e1c4be
Compare
No description provided.