Add fiat transactions history on buy/sell screen by DRadmir · Pull Request #1810 · gemwalletcom/gem-ios

DRadmir · 2026-03-20T17:07:34Z

Simulator Screenshot - iPhone 17 Pro - 2026-03-24 at 13 59 08

Simulator Screenshot - iPhone 17 Pro - 2026-03-23 at 15 07 27

Close: #1807
Close: #1409

gemini-code-assist · 2026-03-20T17:08:15Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant new feature, allowing users to view their fiat transaction history directly within the application's buy/sell interface. It provides a dedicated screen to list all fiat transactions and a detailed view for each, enhancing transparency and user experience for fiat operations. The changes involve new UI components, a dedicated service layer for transaction management, and robust data persistence to ensure transaction history is readily available.

Highlights

Fiat Transaction History UI: Introduced new SwiftUI views (FiatTransactionsScene and FiatTransactionDetailScene) to display a list of fiat transactions and their detailed information within the buy/sell flow.
Fiat Transaction Service: Implemented a new FiatTransactionService responsible for fetching fiat transaction data from the API and persisting it locally using a new FiatTransactionStore.
Data Models and Persistence: Added new data models (FiatTransaction, FiatTransactionStatus) and corresponding GRDB records (FiatTransactionRecord) to support the storage and retrieval of fiat transaction details.
Dependency Injection and Integration: Integrated the new FiatTransactionService across various view models (FiatSceneViewModel, AmountSceneViewModel, ConfirmTransferSceneViewModel) and the application's dependency injection system (AppResolver, ServicesFactory, ViewModelFactory).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a significant new feature: a history screen for fiat transactions. The implementation is well-structured, adding new scenes, view models, services, and database components across the relevant packages. The code follows existing architectural patterns, such as using reactive queries to populate views from a local store. My feedback focuses on improving user experience through better error handling, enhancing accessibility by adjusting color usage, and general code hygiene.

Features/FiatConnect/Sources/ViewModels/FiatTransactionsViewModel.swift

Gem/Services/AppResolver+ViewInjection.swift

Packages/Primitives/TestKit/FiatTransaction+PrimitivesTestKit.swift

Packages/PrimitivesComponents/Sources/ViewModels/FiatTransactionViewModel.swift

@Environment

- Add FiatTransactionsScene (activity list) and FiatTransactionDetailScene with asset preview headers - Add FiatTransactionService for fetching and storing fiat transaction history - Add FiatTransactionStore with GRDB persistence and observable queries - Add FiatTransactionViewModel producing ListItemModel with status tags (pending/failed) - Add FiatTransactionStatusViewModel for consistent status colors - Add FiatProviderName display names and images for providers - Add FiatAmountDisplay for fiat-only transaction headers - Pass fiatTransactionService through model chain from app target (no @Entry/@Environment hack) - Update AmountSceneViewModel and ConfirmTransferSceneViewModel to carry fiatTransactionService - Add navigation from FiatConnectNavigationView to activity list and detail screens - Gray subtitle color for failed transactions, no +/- signs on fiat amounts

Keep only the transaction list for now. Remove: - FiatTransactionDetailScene, ViewModel, and Section types - FiatTransactionRequest (single-item GRDB query) - FiatAmountDisplay and AmountDisplay.fiat case - ExplorerService dependency from FiatConnect - Scenes.FiatTransaction navigation type

…ll-screen

Features/FiatConnect/Sources/Scenes/FiatTransactionsScene.swift

Features/Transfer/Sources/ViewModels/AmountSceneViewModel.swift

Packages/Store/Sources/Models/FiatTransactionRecord.swift

gemcoder21 · 2026-03-23T18:15:55Z

Packages/Store/Sources/Models/FiatTransactionRecord.swift

+                .references(AssetRecord.databaseTableName, onDelete: .cascade, onUpdate: .cascade)
+            $0.column(Columns.transactionType.name, .text)
+                .notNull()
+            $0.column(Columns.providerId.name, .text)


Suggested change

$0.column(Columns.providerId.name, .text)

$0.column(Columns.providerId.name, .jsonText)

we use .text for simple string/enum columns. jsonText is for JSON-encoded structures

Packages/Store/Sources/Models/FiatTransactionRecord.swift

Packages/Store/Sources/Stores/FiatTransactionStore.swift

…conformance Single FiatService handles both fiat API calls and transaction history, removing the dual injection of GemAPIFiatService + FiatTransactionService. Also adds consistent chevron to all fiat transaction rows.

…fiat-transactions-history-on-buy-sell-screen # Conflicts: # Packages/Store/Sources/Migrations.swift

gemdev111 · 2026-03-25T13:05:08Z

Packages/Store/Sources/Requests/FiatTransactionsRequest.swift

+            .filter(FiatTransactionRecord.Columns.walletId == walletId.id)
+            .asRequest(of: FiatTransactionRecordInfo.self)
+            .fetchAll(db)
+            .map { $0.map() }


.order(FiatTransactionRecord.Columns.createdAt.desc)

DateSectionBuilder uses to group by date, the sections will be correct, but items within sections may appear in arbitrary order.

gemdev111 · 2026-03-25T13:07:44Z

Features/FiatConnect/Sources/Scenes/FiatTransactionsScene.swift

+                                ListItemView(model: viewModel.listItemModel)
+                            }
+                        } else {
+                            NavigationCustomLink(


There will be chevron with no action, maybe instead just use ListItemView?

…fiat-transactions-history-on-buy-sell-screen

DRadmir self-assigned this Mar 20, 2026

gemini-code-assist bot reviewed Mar 20, 2026

View reviewed changes

DRadmir added 2 commits March 21, 2026 22:58

DRadmir force-pushed the 1807-add-fiat-transactions-history-on-buy-sell-screen branch from dbd98fc to 851a342 Compare March 21, 2026 18:12

DRadmir added 2 commits March 23, 2026 13:45

Merge branch 'main' into 1807-add-fiat-transactions-history-on-buy-se…

bf94b7f

…ll-screen

Show crypto amount and fiat value on fiat transactions list

1180835

gemcoder21 reviewed Mar 23, 2026

View reviewed changes

DRadmir added 2 commits March 24, 2026 14:02

Merge branch 'main' of github.com:gemwalletcom/gem-ios into 1807-add-…

84eda23

…fiat-transactions-history-on-buy-sell-screen # Conflicts: # Packages/Store/Sources/Migrations.swift

DRadmir marked this pull request as ready for review March 24, 2026 09:05

Update fiat transaction typeshare model

7106c49

DRadmir requested a review from gemcoder21 March 25, 2026 07:22

gemdev111 approved these changes Mar 25, 2026

View reviewed changes

DRadmir added 2 commits March 25, 2026 22:12

Merge branch 'main' of github.com:gemwalletcom/gem-ios into 1807-add-…

885194c

…fiat-transactions-history-on-buy-sell-screen

Order fiat transactions by newest first

7ab661d

DRadmir merged commit 97c9234 into main Mar 25, 2026
1 check was pending

DRadmir deleted the 1807-add-fiat-transactions-history-on-buy-sell-screen branch March 25, 2026 17:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add fiat transactions history on buy/sell screen#1810

Add fiat transactions history on buy/sell screen#1810
DRadmir merged 9 commits intomainfrom
1807-add-fiat-transactions-history-on-buy-sell-screen

DRadmir commented Mar 20, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Mar 20, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemcoder21 Mar 23, 2026

Uh oh!

DRadmir Mar 24, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemdev111 Mar 25, 2026

Uh oh!

gemdev111 Mar 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	$0.column(Columns.providerId.name, .text)
	$0.column(Columns.providerId.name, .jsonText)

Conversation

DRadmir commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Mar 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemcoder21 Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

DRadmir Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemdev111 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

gemdev111 Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DRadmir commented Mar 20, 2026 •

edited

Loading