Conversation
0xh3rman
commented
Mar 24, 2026


HIP-3 builder dex assets require isolated margin. Pass margin type through the full pipeline: Perpetual.onlyIsolated → PerpetualTransferData → PerpetualConfirmData → signer, replacing hardcoded cross margin.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on adding support for HIP3, which introduces the concept of isolated margin to perpetual contracts. The changes involve modifying data models, adjusting order creation processes, and updating the database schema to accommodate the new margin type. The goal is to allow users to choose between isolated and cross margin when trading perpetuals. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for HIP3 by introducing onlyIsolated and marginType properties across various models, services, and view models. The changes are consistent and well-implemented throughout the codebase. I have one suggestion to improve the robustness of the database migration by handling potential errors more explicitly.