Skip to content

Add HIP3 support#1821

Open
0xh3rman wants to merge 2 commits intomainfrom
feature/perpetual-margin-type
Open

Add HIP3 support#1821
0xh3rman wants to merge 2 commits intomainfrom
feature/perpetual-margin-type

Conversation

@0xh3rman
Copy link
Contributor

Simulator Screenshot - iPhone 17 - 2026-03-24 at 18 25 19 Simulator Screenshot - iPhone 17 - 2026-03-24 at 18 25 24
Simulator Screenshot - iPhone 17 - 2026-03-24 at 18 25 32 Simulator Screenshot - iPhone 17 - 2026-03-24 at 18 25 29

HIP-3 builder dex assets require isolated margin. Pass margin type
through the full pipeline: Perpetual.onlyIsolated → PerpetualTransferData
→ PerpetualConfirmData → signer, replacing hardcoded cross margin.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on adding support for HIP3, which introduces the concept of isolated margin to perpetual contracts. The changes involve modifying data models, adjusting order creation processes, and updating the database schema to accommodate the new margin type. The goal is to allow users to choose between isolated and cross margin when trading perpetuals.

Highlights

  • HIP3 Support: This PR introduces support for HIP3, which likely involves changes to how perpetual contracts are handled, particularly regarding margin types (isolated vs. cross).
  • Margin Type Handling: The PR adds a marginType property to PerpetualConfirmData and PerpetualTransferData, indicating whether the margin is isolated or cross. This affects order creation and position management.
  • Database Migration: A database migration is included to add an onlyIsolated column to the PerpetualRecord table, defaulting to false. This suggests that existing perpetual contracts will default to cross margin.
  • Code Adjustments: Several code adjustments were made to pass the marginType when creating transfer data and confirming orders, ensuring the correct margin type is used for each transaction.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for HIP3 by introducing onlyIsolated and marginType properties across various models, services, and view models. The changes are consistent and well-implemented throughout the codebase. I have one suggestion to improve the robustness of the database migration by handling potential errors more explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant