Fix invalid header image when transferring NFT (#1813)

[gemdev111]

• Extract NftPreviewView for consistent NFT image display
• Show proper NFT preview in recipient scene for NFT transfers
• Reuse NftPreviewView in TransactionHeaderView

closes #1813

images:

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where NFT header images were not displayed correctly during transfers. It introduces a new, reusable NftPreviewView component to standardize how NFT images and names are presented across different parts of the application. The recipient scene for NFT transfers has been updated to use this new component, ensuring proper image display, and the TransactionHeaderView has also been refactored to adopt NftPreviewView, improving consistency and maintainability.

Highlights

• Introduced NftPreviewView component: A new reusable SwiftUI view was created to consistently display NFT images and names, encapsulating the layout and styling logic.
• Improved NFT display in Recipient Scene: The transfer recipient screen now correctly displays NFT header images by utilizing the new NftPreviewView and a dedicated image generation function within the view model.
• Refactored TransactionHeaderView: The existing TransactionHeaderView was updated to leverage the new NftPreviewView for displaying NFT details, promoting code reuse and consistency across the application.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for displaying NFT assets in the recipient scene by refactoring the header view to dynamically show either asset or NFT previews. A new NftPreviewView component was added for reusability, and the TransactionHeaderView was updated to utilize it. Additionally, a new function nftAssetImage was added to RecipientSceneViewModel to generate image assets for NFTs, along with a corresponding test. A review comment suggests an improvement in RecipientSceneViewModel.swift to use the shared instance of AssetImageFormatter for better efficiency.

[gemini-code-assist]

It is more efficient and idiomatic to use the shared instance of AssetImageFormatter rather than creating a new instance each time nftAssetImage is called. This avoids unnecessary object allocations.

Suggested change

	imageURL: AssetImageFormatter().getNFTUrl(for: nftAsset.id),
	imageURL: AssetImageFormatter.shared.getNFTUrl(for: nftAsset.id),