Fix empty transaction participants in history

[DRadmir]

Fix: #1819

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where transaction participant details, such as 'From' or 'To' labels, were displayed even when the corresponding address was empty, leading to a confusing user interface in the transaction history. The changes refactor the logic responsible for generating these titles, ensuring that only valid and non-empty participant information is presented to the user. Additionally, related address handling in staking flows has been streamlined, and new tests have been introduced to validate the correct behavior of these display rules.

Highlights

• Transaction Participant Display Logic: Refactored the TransactionViewModel to introduce a new participantTitle helper function. This function ensures that transaction participant addresses are only displayed if they are not empty, preventing 'From ' or 'To ' labels from appearing without an actual address in the transaction history.
• Improved Address Handling in Staking: Simplified the logic for determining recipient addresses in AmountStakeViewModel by directly using the validator's ID, removing a redundant helper function and streamlining address resolution.
• Enhanced Test Coverage: Added new unit tests to TransactionViewModelTests specifically to verify that the titleExtraTextValue correctly returns nil when participant or sender addresses are empty, ensuring the fix behaves as expected.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the TransactionViewModel to improve how participant titles are generated and displayed. A new helper function, participantTitle, was introduced to encapsulate the formatting logic, and the getDisplayName function was updated to handle empty addresses gracefully. Corresponding unit tests were added to ensure that extra title text is hidden when participant or sender addresses are empty. Additionally, the AmountStakeViewModel was simplified by removing the recipientAddress helper function and directly using the validatorId as the recipient address. I have no feedback to provide.

[gemcoder21]

Suggested change

	let value = getDisplayName(address: address, chain: chain).trimmingCharacters(in: .whitespacesAndNewlines)
	let value = getDisplayName(address: address, chain: chain)