Skip to content

Remove dead public code in core crates - #858

Merged
gemcoder21 merged 2 commits into
mainfrom
chore/core-remove-dead-public
Aug 9, 2026
Merged

Remove dead public code in core crates#858
gemcoder21 merged 2 commits into
mainfrom
chore/core-remove-dead-public

Conversation

@0xh3rman

@0xh3rman 0xh3rman commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Removes 87 public items that are unreachable from every core workspace binary, test, and bench. 48 files, +21/−461.

  1. Found with cargo-hawk reachability analysis over the core workspace, with gemstone and primitives excluded as mobile-facing API boundaries; each finding was additionally checked against iOS/Android generated bindings, feature-gated tests, and macro codegen before removal
  2. Per git history, 41 items are refactor leftovers (last callers removed by the repository-trait migrations and similar refactors) and 46 never had a caller in any commit (wrappers added alongside the form that is used, unused encode/decode codec halves, unwired testkit fixtures)
  3. The gem_encoding protobuf decoder still consumes fixed32 wire fields for cursor correctness; only the never-read payload accessor is removed
  4. Verified: cargo check --workspace, cargo clippy --workspace -- -D warnings, cargo test --lib --bins --workspace --features unit_tests (2319 passed), and a hawk re-run reporting zero remaining dead public items

1. Remove 87 public items unreachable from any workspace binary or test, found with cargo-hawk and verified against mobile bindings and feature-gated tests
2. Drop the unused fixed32 payload in the gem_encoding protobuf decoder; the parser still consumes fixed32 fields
3. Verified with workspace check, clippy -D warnings, unit test suite, and a clean hawk re-run
@0xh3rman
0xh3rman marked this pull request as ready for review August 9, 2026 00:32
@gemcoder21
gemcoder21 merged commit ff42026 into main Aug 9, 2026
7 checks passed
@gemcoder21
gemcoder21 deleted the chore/core-remove-dead-public branch August 9, 2026 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants