ci: split wellness-check + add doc/miri/sanitizer jobs#11
Merged
Conversation
… coverage Restructured `wellness-check.yaml` modeled on the same upgrade applied to amygdala (PR gen0sec/amygdala#3): * split monolithic `fmt-and-test` into independent `fmt`, `clippy`, `doc`, `unit-tests`, `e2e` jobs so a fmt nit no longer gates the slow tests * added `doc` job with `RUSTDOCFLAGS=-D warnings` to catch broken intra-doc links / stale rustdoc * added `miri` job (`--no-default-features --lib`, `MIRIFLAGS=-Zmiri-disable-isolation -Zmiri-permissive-provenance`, `timeout-minutes: 45`) — UB detection for the pure-Rust core * added `sanitizers` matrix (`address`, `thread`, `leak`) on `-Zbuild-std`, also pure-Rust core to avoid FFI false positives * added top-level `concurrency` group to cancel superseded runs * added `--locked` to every cargo invocation * added `push: branches` trigger so post-merge regressions surface * job DAG: heavy jobs `needs: [fmt, clippy]` so they short-circuit Semgrep skipped — gen0sec uses Dependabot for SCA coverage.
Adds a fast `machete` job to wellness-check.yaml that runs
`cargo machete` (action `bnjbvr/cargo-machete@v0.9.2`, pinned by
SHA) to detect unused entries in `Cargo.toml`. Catches dep drift
that would otherwise silently bloat the build / publish surface.
Per-repo Cargo.toml updates so the gate is green at landing:
* remove genuinely unused deps (where any existed)
* add `[package.metadata.cargo-machete] ignored = [...]` for
optional build-deps and renamed-import crates that machete
structurally can't see (build.rs invocations, feature-gated
deps, and `wirefilter-engine` imported as `wirefilter::`).
Each ignored entry is commented with the reason.
Wellness-check now runs every cargo command with `--locked` for reproducibility. Drop Cargo.lock from .gitignore (current Cargo team guidance for libraries) so CI reproduces exact dep versions and the new gate works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same wellness-check upgrade just landed on amygdala (gen0sec/amygdala#3). Restructured
wellness-check.yamlmodeled on the wirefilter Rust workflow.fmt-and-testinto parallelfmt,clippy,doc,unit-tests,e2ejobs.docjob (RUSTDOCFLAGS=-D warnings) to catch broken intra-doc links.mirijob (pure-Rust core,--no-default-features --lib,MIRIFLAGS=-Zmiri-disable-isolation -Zmiri-permissive-provenance,timeout-minutes: 45).sanitizersmatrix (address/thread/leak) via-Zbuild-std.concurrencygroup;--lockedeverywhere;push: branchestrigger.e2e/miri/sanitizersallneeds: [fmt, clippy].Semgrep deliberately not added — Dependabot is the org's SCA path.
Test plan
main