Open
Conversation
Collaborator
YuWei-CH
commented
Oct 23, 2024
YuWei-CH
commented
- Add a check_files_not_empty() in job.py to ensure that user uploaded file is not empty
- I would like to suggest that, regardless of whether we succeed or not, we should keep the upload folder. While reform.py can run successfully, there is a very small chance that the user might still get an incorrect result due to potential bugs in reform.py. If you believe this possibility can be safely ignored, I will update the code to remove the upload folder when the process completes successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.