Fix strcmp treating null and empty strings as equal#1069
Merged
Conversation
Previously, strcmp could return equality when comparing a null value with an empty string. This happened because rtrim(null) returned an empty string, causing null and "" to be treated as equivalent during comparison. This change preserves the semantic difference between null and empty strings by handling null values explicitly and delegating comparison to Comparator.nullsFirst after trimming. Behavior: - null is considered less than any non-null String - empty strings are not equal to null - trailing whitespace is ignored during comparison Issue: 207440
Collaborator
Cherry pick to beta success |
Collaborator
Cherry pick to beta success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, strcmp could return equality when comparing a null value with an empty string.
This happened because rtrim(null) returned an empty string, causing null and "" to be treated as equivalent during comparison.
This change preserves the semantic difference between null and empty strings by handling null values explicitly and delegating comparison to Comparator.nullsFirst after trimming.
Behavior:
Issue: 207440