Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions flows/prefect.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -237,3 +237,17 @@ deployments:
schedules:
- *daily
work_pool: *goat_data_work_pool

- name: update-tol-portal-status
# This flow updates the status milestones of projects in the ToL portal
entrypoint: flows/updaters/update_tol_portal_status.py:update_tol_portal_status
parameters:
# Local path to save the ToL portal status TSV file
output_path: "/home/ubuntu/tmp/test/status-lists/tol_project_status_expanded.tsv"
Comment on lines +245 to +246
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider avoiding a hard-coded environment-specific output path.

Using an absolute path under /home/ubuntu/tmp/test/... ties this to a specific machine and likely a temporary directory. Please make this path configurable (e.g., parameter default, env var, or shared base directory) so the flow can run cleanly in other environments.

Suggested change
# Local path to save the ToL portal status TSV file
output_path: "/home/ubuntu/tmp/test/status-lists/tol_project_status_expanded.tsv"
# Local path to save the ToL portal status TSV file (relative; override per-environment via deployment parameters)
output_path: "status-lists/tol_project_status_expanded.tsv"

# The S3 path to save the ToL portal status TSV file
s3_path: s3://goat/resources/status-lists/tol_project_status_expanded.tsv
# Minimum number of records expected in the ToL portal status
min_records: 8300
schedules:
- *daily
work_pool: *goat_data_work_pool
Loading