fix Unknown quickjs tag: -6 error for long input strings#8
Open
robinvandernoord wants to merge 1 commit into
Open
fix Unknown quickjs tag: -6 error for long input strings#8robinvandernoord wants to merge 1 commit into
Unknown quickjs tag: -6 error for long input strings#8robinvandernoord wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I was using quickjs-ng to transpile some typescript into javascript, I ran into the following exception:
Tag -6 corresponds to
JS_TAG_STRING_ROPE, which is not currently handled inquickjs_to_python. This causes failures when QuickJS returns rope strings (e.g. from large template literals).This PR adds handling for
JS_TAG_STRING_ROPEby treating it the same asJS_TAG_STRING.I've extracted my use-case as a replication using a silly large template literal here:
demo.py
After this change, the demo works and
make teststill passes.