allow specifying multiple pgp keys to the cli#37
Closed
Jturnerusa wants to merge 1 commit into
Closed
Conversation
Member
|
The commit message should always reflect the PR description (at least any useful parts). Needs I would also add |
Jturnerusa
force-pushed
the
feature/multiple-keyrings
branch
5 times, most recently
from
127f825 to
26e67c1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Jturnerusa
force-pushed
the
feature/multiple-keyrings
branch
from
26e67c1 to
c0d0918
Compare
mgorny
requested changes
Sep 15, 2025
Comment on lines
+1286
to
+1289
| if expected == "pass": | ||
| assert retval == 0 | ||
| else: | ||
| assert retval != 0 |
Member
There was a problem hiding this comment.
Store retval in the fixture instead?
Author
There was a problem hiding this comment.
What do you mean by store it in the fixture?
Jturnerusa
force-pushed
the
feature/multiple-keyrings
branch
from
c0d0918 to
191a460
Compare
This will allow gemato to be used for example in the git-r3 eclass to verify git commit signatures, where importing multiple keys may be required. Bug: https://bugs.gentoo.org/913390 Signed-off-by: John Turner <jturner.usa@gmail.com>
Jturnerusa
force-pushed
the
feature/multiple-keyrings
branch
from
191a460 to
b695f0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to use gemato in the git-r3 eclass to verify git commit signatures in live ebuilds, but this may require importing multiple keys, since repos can have multiple people working on them at once.
This is a pretty small change and tests seem to pass, but it could probably use some real work testing too which I will do in my local overlay when I patch git-r3.eclass!