Minimum bets are invalid from previous rounds#6
Open
Froren wants to merge 1 commit intogeobalas:masterfrom
Open
Minimum bets are invalid from previous rounds#6Froren wants to merge 1 commit intogeobalas:masterfrom
Froren wants to merge 1 commit intogeobalas:masterfrom
Conversation
- Minimum bet amounts would roll over from previous rounds, a test is still needed to verify the fix - Added `npm test` command in package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an issue where a large bet in a certain round will influence the minimum bet of later rounds, which is a problem for general gameplay.
I didn't get a chance to figure out how to write the working test for this scenario though.