Skip to content

fix: make Subtopics modal tree items link to their topic entity #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webmagic123 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: make Subtopics modal tree items link to their topic entity #2011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion apps/web/partials/space-page/subtopics-tree-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ export function SubtopicsTreeView({ spaceId, rootEntityId, onAddSubtopic, onNavi
isRoot
defaultExpanded
onAddSubtopic={onAddSubtopic}
onNavigate={onNavigate}
/>
</div>
</>
Expand Down Expand Up @@ -172,6 +173,7 @@ function SubtopicTreeNode({
relationId,
defaultExpanded = false,
onAddSubtopic,
onNavigate,
}: {
entityId: string;
name: string;
Expand All @@ -185,6 +187,7 @@ function SubtopicTreeNode({
relationId?: string;
defaultExpanded?: boolean;
onAddSubtopic: (target: AddSubtopicTarget) => void;
onNavigate?: () => void;
}) {
const [expanded, setExpanded] = React.useState(defaultExpanded);
const [menuOpen, setMenuOpen] = React.useState(false);
Expand Down Expand Up @@ -244,7 +247,13 @@ function SubtopicTreeNode({
</span>
</button>

<span className="min-w-0 flex-1 truncate text-button text-current">{name}</span>
<Link
href={NavUtils.toEntity(spaceId, entityId)}
onClick={() => onNavigate?.()}
className="min-w-0 flex-1 truncate text-button text-current hover:underline"
>
{name}
</Link>

{canEdit && (
<Menu
Expand Down Expand Up @@ -303,6 +312,7 @@ function SubtopicTreeNode({
parentName={name}
relationId={child.relationId}
onAddSubtopic={onAddSubtopic}
onNavigate={onNavigate}
/>
))}
</div>
Expand Down
Loading