Improve list and gallery data block readability - #2015
Draft
jwalkingjew wants to merge 2 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves readability and visual alignment for the table block’s list and gallery “browse” cards by increasing typography sizes for titles/body text and tightening spacing above vote controls.
Changes:
- Increased browse body/value typography from metadata to list-item token sizing.
- Centralized entity title styling via a shared
LIST_GALLERY_BROWSE_TITLE_CLASSusing the card-entity-title token. - Reduced the top margin above vote controls in both list and gallery items.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/web/partials/blocks/table/table-block-property-field.tsx | Updates browse property value/link typography to use the listItem token sizing. |
| apps/web/partials/blocks/table/table-block-list-item.tsx | Uses shared browse title class and reduces vote-row top spacing in list layout. |
| apps/web/partials/blocks/table/table-block-gallery-item.tsx | Uses shared browse title class and reduces vote-row top spacing in gallery layout. |
| apps/web/partials/blocks/table/table-block-browse-layout.ts | Introduces shared browse title class and updates shared browse body typography token sizing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
List and gallery data-block cards were difficult to scan because entity names and descriptions rendered too small, while the vote controls had more vertical separation from the content than needed.
Impact
Entity names and supporting content are easier to read, and the vote row sits closer to each card's content in both list and gallery layouts.
Validation
bunx tsc --noEmit --pretty falsegit diff --check