Add a safe version of parsing broma files so that the code doesn't have to exit - #7
Open
CallocGD wants to merge 8 commits into
Open
Add a safe version of parsing broma files so that the code doesn't have to exit#7CallocGD wants to merge 8 commits into
CallocGD wants to merge 8 commits into
Conversation
Author
|
Nevermind I think I just made it better Gonna do a few more tweaks |
Author
|
Done. |
|
Should be closed as parse_file now uses Geode's own result library for error-handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a problem with pybroma where the script will exit when it shouldn't when handling lets just say multiple at a time and I am planning to make a discord bot that can summarize the geode bindings and other important elements and with a rust port on the way getting this in here felt like a must for me as the
std::exit(1)part of this code infuriates me greatly as it's just not proper error handling if that makes any sense to anybody. I feel like error handling should be customized rather than simply exiting. when something is wrong, This was my attempt at writing a solution I had another idea to use a something similar to astd::pairfor handling the result if required incase this pull request gets rejected.