Added IDs to LevelSettingsLayer#171
Open
Flaks45 wants to merge 2 commits into
Open
Conversation
Member
|
the main reason it was so lengthy was bc it was the 2.1 code, where the level settings looked a little bit different. it also separated stuff into separate menus with layouts, whereas this one doesn't. i would say having separate layouts, like the old code, would be nice |
Author
|
didn't notice it was 2.1 code, that makes more sense now. About the layouts, 2.1 had more rows and columns that cleanly fit as other menus, and I didn't want to risk creating confusing menus (like the colors being in a layout while most other buttons stayed in another menu). If you have any ideas please lmk, otherwise I will commit again with IDs closer to the 2.1 version and that will be it |
…mod, common element separated as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This layer is also used for Start Pos, not too sure why the old commented code was lengthy (since options are in SelectSettingLayer, LevelOptionsLayer, SelectArtLayer, ColorSelectPopup etc etc)