fix: consolidate CLI/services duplication (Phase 1 audit remediation)#20
Merged
Conversation
- Refactor cli._scan_single() to use services.scan_project() as single source of truth for scan logic - Remove redundant _invoke_check import alias from CLI - Add docstring to services._invoke_check() for clarity - Update test to verify consolidated _invoke_check location Fixes F1, F2, F5 from audit intake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors CLI scan logic to use
services.scan_project()as the single source of truth, eliminating duplicated code betweencli._scan_single()andservices.scan_project().Changes
_scan_single()to useservices.scan_project()instead of duplicating scan logic_invoke_check(), extractedparamsvariable for clarity_invoke_checklocationAudit Findings Fixed
_scan_single()duplicatesservices.scan_project()✅_invoke_check_cliimport alias ✅_invoke_checkdouble-invoke bug (documented, clarified behavior) ✅Testing
Phase 1 of 6
This is Phase 1 of the audit remediation roadmap. See #15 for full roadmap.