fix: fix CLI behavior issues (Phase 3 audit remediation)#22
Merged
Conversation
- Add --fail-on-warning flag (exits with code 1 on warnings) - Fix --pretty flag inversion (now defaults to False) - Add --no-pretty flag for explicit disabling - Document config fallback behavior in _load_check_config() Fixes F3, F4, F6 from audit intake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CLI behavior issues: exit code semantics, flag inversion, and config fallback documentation.
Changes
--fail-on-warningflag (exits with code 1 if warnings found)--prettyflag inversion (now defaults to False, use--prettyto enable)--no-prettyflag for explicit disabling_load_check_config()Audit Findings Fixed
--fail-on-warningoption ✅--prettyflag (no longer inverted) ✅Testing
Phase 3 of 6
This is Phase 3 of the audit remediation roadmap.