fix: add Linux sample paths, expand CI to macOS + Windows (Phase 4)#23
Merged
Conversation
…dit remediation) - Add Linux support to known_sample_dirs() in search.py - Add macos-latest and windows-latest to CI test matrix - Add macos-15-intel to build matrix for x86_64 macOS - Replace deprecated macos-14 with macos-15 for ARM64 builds Fixes F12, F13, F15 from audit intake.
- Add macos-15-intel to test matrix - Test Python 3.14 (not 3.12) on macOS and Windows - Keep full Python range (3.12, 3.13, 3.14) on Linux
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds platform parity: Linux sample search support, cross-platform CI testing, and correct macOS build matrix.
Changes
_linux_sample_dirs()function with~/.ableton/paths, refactored platform detection into dedicated_windows_sample_dirs()/_macos_sample_dirs()/_linux_sample_dirs()functionsmacos-latestandwindows-latest(single Python 3.12 each to control CI cost)macos-15-intelfor x86_64 macOS buildsmacos-14withmacos-15for ARM64 buildsAudit Findings Fixed
known_sample_dirs()✅Build Matrix (4 binaries)
alscan-x86_64-linux.tar.gzubuntu-latestalscan-aarch64-macos.tar.gzmacos-15alscan-x86_64-macos.tar.gzmacos-15-intelalscan-x86_64-windows.zipwindows-latestTesting
Phase 4 of 6
This is Phase 4 of the audit remediation roadmap.