Skip to content

[Clang-format] Update clang-format in continuous integrator to use a more recent version (v 18.1.8)#118

Merged
bodhinandach merged 8 commits intomasterfrom
clang-format/update
Apr 8, 2026
Merged

[Clang-format] Update clang-format in continuous integrator to use a more recent version (v 18.1.8)#118
bodhinandach merged 8 commits intomasterfrom
clang-format/update

Conversation

@bodhinandach
Copy link
Copy Markdown
Member

Describe the PR
Clang-format has long been updated to newer versions; the one we used in the Docker was set at v10. Some of the old formatting styles have been deprecated, which causes many repetitive conflicts if one runs with more recent clang-format locally.

This PR updates the default version considered in the continuous integrator (for testing purposes) to v18. It is not the newest version, but compatible with major Linux Ubuntu and macOS distributions used by the group.

Related Issues/PRs
N/A

Additional context
N/A

@bodhinandach bodhinandach requested a review from cgeudeker March 17, 2026 03:21
@bodhinandach bodhinandach self-assigned this Mar 17, 2026
@bodhinandach bodhinandach added documentation Improvements or additions to documentation cleanup Improvements in information and code organization labels Mar 17, 2026
@bodhinandach bodhinandach marked this pull request as ready for review March 17, 2026 03:21
@bodhinandach bodhinandach changed the title [Clang-format] Update clang-format in continuous integrator to use a more recent version (v 18.1.3) [Clang-format] Update clang-format in continuous integrator to use a more recent version (v 18.1.8) Mar 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.76%. Comparing base (b690d4a) to head (8707c32).
⚠️ Report is 61 commits behind head on master.

Files with missing lines Patch % Lines
include/loads_bcs/displacement_constraint.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   95.76%   95.76%   -0.00%     
==========================================
  Files         244      244              
  Lines       51467    51470       +3     
==========================================
+ Hits        49284    49286       +2     
- Misses       2183     2184       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@cgeudeker cgeudeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me.

@bodhinandach bodhinandach merged commit bcaa78a into master Apr 8, 2026
7 of 8 checks passed
@bodhinandach bodhinandach deleted the clang-format/update branch April 8, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Improvements in information and code organization documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants