bring back SP + disable all not needed services + update rabbitmq healthcheck#305
bring back SP + disable all not needed services + update rabbitmq healthcheck#305
Conversation
7c9f0cf to
dc6cf93
Compare
f-necas
left a comment
There was a problem hiding this comment.
Scale's nice but it doesn't it's not obvious than the container isn't start at first look of docker compose file. I prefer comments rather than scale.
Scale doesn't involve git conflicts when the optional service gets its image updated, for example. If you uncomment a service, but we update the image, then you have to resolve the conflict because all the lines have been uncommented on your side. Also, the "comment" way doesn't make sense for the services that will probably be wanted by a lot of people, like rabbitmq. Very few people want SP, analytics or CAS but rabbitmq a lot of people will need it. In my opinion, "scale" is solving the issue on both sides. Solving the issue of not running a service by default and make it easy to keep few divergences with the upstream docker composition. I think what I can do is to reorder the docker-compose file structure. Like all the required services are ordered first, then you have a comment stating these services are optional, and after you have the group of optional services. Here is an example: version: "3.1"
volumes:
services:
required1:
required2:
# Optional services:
optional1:
optional2:What do you think? |
dc6cf93 to
9a6fe65
Compare
|
Ok then to re-order services. Could you also add geocontrib ? There's already a geocontrib branch with it |
no geocontrib is not part of the official georchestra stack. |
This pull request aims to add back the services that shouldn't entirely be removed, like security-proxy.
This PR has these services disabled by default, thanks to "scale: 0":
RabbitMQ is not a hard requirement, so there is no point in having it enabled by default.
I have also updated rabbitmq healthcheck because
rabbitmq-diagnostics -q check_local_alarmsslow down the ability for the service to become healthy.