Skip to content

use assert_root to check whether user is root when '-r' option is used #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bpostalci wants to merge 5 commits into
base: master
Choose a base branch
from
Open

use assert_root to check whether user is root when '-r' option is used #116

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
892a7dc
create assert_root function that checks whether the user has root pri…
May 21, 2020
c36a2ca
fix typo in assert_root function's comment
May 21, 2020
9fec9d2
change logging.warn to logging.warning to remove depreciation warning
May 21, 2020
876e793
fix typo in assert_root function's comment
May 21, 2020
82bf6fb
use assert_root to check whether user is root when '-r' option is used
Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion undervolt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ def write_msr(val, addr):
values from register addr.
Writes to all msr node on all CPUs available.
"""
assert_root()

for i in valid_cpus():
c = '/dev/cpu/%d/msr' % i
if not os.path.exists(c):
Expand All @@ -84,6 +86,8 @@ def read_msr(addr, cpu=0):
"""
Read a value from single msr node on given CPU (defaults to first)
"""
assert_root()

n = '/dev/cpu/%d/msr' % (cpu,)
f = os.open(n, os.O_RDONLY)
os.lseek(f, addr, os.SEEK_SET)
Expand Down Expand Up @@ -348,6 +352,12 @@ def read_ac_state():
# Assume no battery if the /sys entry is missing.
return True

def assert_root():
"""
Checks whether the user has root privileges, exit otherwise
"""
if os.geteuid() != 0:
exit("You need to have root privileges to run this script with these options.\nRerun with 'sudo'.")

def main():
parser = argparse.ArgumentParser()
Expand Down Expand Up @@ -383,10 +393,11 @@ def main():
msr = ADDRESSES

if not glob('/dev/cpu/*/msr'):
assert_root()
subprocess.check_call(['modprobe', 'msr'])

if (args.core or args.cache) and args.core != args.cache:
logging.warn(
logging.warning(
"You have supplied different offsets for Core and Cache. "
"The smaller of the two (or none if you only supplied one) will be applied to both planes."
)
Expand Down