RedisOrm.redis to set proper redis instance/DB#7
Open
redrick wants to merge 3 commits intogerman:masterfrom
Open
RedisOrm.redis to set proper redis instance/DB#7redrick wants to merge 3 commits intogerman:masterfrom
redrick wants to merge 3 commits intogerman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi there,
first of all thanks for the gem :)
I found a bit odd thing, you were using $redis instance to work with, but I already got that full of data of other kind and I actually use 10 out of 16 redis DBs available to us... and one of them has to be $redis already and I don't want to mix these two together...
Therefore what I did here I gave myself redis variable to module RedisOrm, so I can freely set it for example to this:
RedisOrm.redis = Redis.new(db:'9')and BANG I got it separated and I am satisfied now :)I already added info into readme, and also tests are still passing, I hope you merge and upload to rubygems, for now I am stuck with my github, looking forward to merge :)
have a nice day 🌞