Fix units and registers #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no "Kelvin degrees", it's always just Kelvins.
This is stated in the "58101758_B1_GB_02.2021" document (Modbus register mapping, Modbus RTU, Modbus/KMP TCP/IP"). It also makes sense, looking at all the other values in the table.
These data come from the "58101758_B1_GB_02.2021" document (Modbus register mapping, Modbus RTU, Modbus/KMP TCP/IP"). I have not seen them in my meters, but given that all the other values match, I\d say there's a high chance of them being correct.
This is speculative (I have no KMP-speaking electricity meter with an IEC optical port), but given that the "kvar" is already defined, and looking at the other units, this is very likely a typo.
Some of these calculators support multiple flow meters, so let's identify which "channel" this is using.
The datasheet has this information, so let's include it in the source code.
Almost all of these were cross-checked against a number of PDFs which I found on the web. The exceptions are documented in the code: - 259 is very likely the Q_p, aka the nominal flow, - 400 is an educated guess, a one-decimal-digit precise T1-T2 difference - 675 is only there on our WM-Bus enabled Multical 303 which were procured with a transmission interval of 96 seconds I'm using decimal numbers instead of hex because that's what the vast majority of the documents use. I'll change the existing constants in a follow-up commit.
The vast majority of the vendor-provided documentation uses decimal numbers as the primary format -- and so does this tool in its default output. I only found a couple of documents which used hex numbers, and in these cases they were always accompanied with the decimal equivalent. I saw no instance of hexadecimal with no decimal equivalents. I checked that the resulting content of the list is exactly the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for an awesome tool. We have 10 pcs of Multical 603 and 148 of Multical 303, this PR is a result of some quick toying around with Zenovate/Tespro OP-BT optical head. Please review the individual commits for more details, this is just a summary:
Wandvarwith no prefix\N{THAT GLYPH NAME}syntax, yay)The unit tests all pass. Some of your linters produce a diff which touches files that I have not modified, and I cannot run
ruffin my env. Hope this is OK.