Skip to content

use convex linter#255

Open
ianmacartney wants to merge 4 commits into
mainfrom
ian/convex-linter
Open

use convex linter#255
ianmacartney wants to merge 4 commits into
mainfrom
ian/convex-linter

Conversation

@ianmacartney
Copy link
Copy Markdown
Member

Summary

  • Install and configure @convex-dev/eslint-plugin
  • Auto-fix explicit-table-ids violations (adds table name as first arg to db.get/db.patch/db.delete/db.replace)
  • Add eslint-disable annotations where table names are genuinely dynamic

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 25, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: get-convex/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b1ab6cea-0c40-4e1e-8362-69415b262342

📥 Commits

Reviewing files that changed from the base of the PR and between 36988ac and cda7ddc.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (28)
  • .github/workflows/test.yml
  • eslint.config.js
  • example/convex/approval.test.ts
  • example/convex/chat/approval.ts
  • example/convex/usage_tracking/invoicing.ts
  • example/ui/chat/ChatApproval.tsx
  • example/ui/main.tsx
  • package.json
  • playground/src/components/ui/badge.tsx
  • playground/src/components/ui/button.tsx
  • playground/src/components/ui/sheet.tsx
  • src/UIMessages.ts
  • src/client/approval.test.ts
  • src/client/createTool.ts
  • src/client/index.ts
  • src/client/saveInputMessages.ts
  • src/client/streaming.integration.test.ts
  • src/client/types.ts
  • src/component/apiKeys.ts
  • src/component/files.test.ts
  • src/component/files.ts
  • src/component/messages.ts
  • src/component/streams.ts
  • src/component/threads.ts
  • src/component/users.ts
  • src/component/vector/index.ts
  • src/mapping.test.ts
  • src/mapping.ts
💤 Files with no reviewable changes (1)
  • example/ui/main.tsx

📝 Walkthrough

Walkthrough

This PR modernizes the codebase by migrating Convex database operations from ID-only calls to table-qualified calls throughout the application. The change adds explicit table names to all database operations (ctx.db.get("tableName", id) instead of ctx.db.get(id)), improves vector embedding coordination through explicit table resolution, integrates the Convex ESLint plugin for code quality, and wires new example routes. The updates affect core data access layers (messages, files, threads, streams, users, vectors) and include comprehensive test and formatting improvements.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'use convex linter' directly and clearly summarizes the main objective of the PR: installing and configuring the Convex ESLint plugin.
Description check ✅ Passed The description clearly explains the three main changes: installing the ESLint plugin, auto-fixing explicit-table-ids violations, and adding eslint-disable annotations where needed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ian/convex-linter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 25, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@convex-dev/agent@255

commit: cda7ddc

@ianmacartney ianmacartney requested a review from sethconvex April 27, 2026 22:41
ianmacartney and others added 4 commits May 19, 2026 22:11
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Member Author

@robelest would you mind seeing if there's anything in here that didn't already get applied in other PRs and merging/closing it? Thanks!

@robelest
Copy link
Copy Markdown
Collaborator

@robelest would you mind seeing if there's anything in here that didn't already get applied in other PRs and merging/closing it? Thanks!

Yeah Ill check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants