Skip to content

chore(deltas): delete legacy TextStreamPart streaming path #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robelest wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore(deltas): delete legacy TextStreamPart streaming path #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ba2adc5
fix(react): O(n²) lag streaming long tool-input deltas (#190)
robelest May 22, 2026
c7929d8
refactor(react): single incremental path for streaming UIMessages
robelest May 24, 2026
c11d91b
review: address CodeRabbit feedback (drop stale tool buffers, rename …
robelest May 27, 2026
ff22c69
fix(deltas): drop async from applyUIMessageChunksIncremental
robelest May 27, 2026
00c129c
chore(deltas): delete legacy TextStreamPart streaming path
robelest May 27, 2026
995691a
fix(deltas): address CodeRabbit feedback on TextStreamPart deletion
robelest May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
75 changes: 3 additions & 72 deletions src/client/streaming.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
import {
getParts,
deriveUIMessagesFromDeltas,
deriveUIMessagesFromTextStreamParts,
} from "../deltas.js";
import type { TestConvex } from "convex-test";
import type { StreamDelta, StreamMessage } from "../validators.js";
Expand Down Expand Up @@ -677,77 +676,6 @@ describe("Delta Stream Consumption", () => {
expect((parts[0] as { type: string }).type).toBe("new");
expect(cursor).toBe(6);
});

test("TextStreamPart format delta reconstruction with tool calls", () => {
const streamId = "s1";
const streamMessage: StreamMessage = {
streamId,
order: 1,
stepOrder: 0,
status: "streaming",
};
const deltas: StreamDelta[] = [
{
streamId,
start: 0,
end: 1,
parts: [{ type: "text-delta", id: "txt-0", text: "Let me call a tool. " }],
},
{
streamId,
start: 1,
end: 2,
parts: [
{
type: "tool-call",
toolCallId: "tc1",
toolName: "search",
input: { query: "hello" },
},
],
},
{
streamId,
start: 2,
end: 3,
parts: [
{
type: "tool-result",
toolCallId: "tc1",
toolName: "search",
output: "Found 3 results",
},
],
},
{
streamId,
start: 3,
end: 4,
parts: [
{ type: "text-delta", id: "txt-1", text: "Here are the results." },
],
},
];

const [messages, , changed] = deriveUIMessagesFromTextStreamParts(
"thread1",
[streamMessage],
[],
deltas,
);

expect(messages).toHaveLength(1);
expect(changed).toBe(true);

const msg = messages[0];
expect(msg.text).toContain("Let me call a tool.");
expect(msg.text).toContain("Here are the results.");

const toolParts = msg.parts.filter((p: any) =>
p.type.startsWith("tool-"),
);
expect(toolParts.length).toBeGreaterThan(0);
});
});

// ============================================================================
Expand Down Expand Up @@ -879,18 +807,21 @@ describe("Fallback Behavior", () => {
order: 0,
stepOrder: 0,
status: "streaming",
format: "UIMessageChunk",
};
const finishedMsg: StreamMessage = {
streamId: "s2",
order: 1,
stepOrder: 0,
status: "finished",
format: "UIMessageChunk",
};
const abortedMsg: StreamMessage = {
streamId: "s3",
order: 2,
stepOrder: 0,
status: "aborted",
format: "UIMessageChunk",
};

const msgs = await deriveUIMessagesFromDeltas(
Expand Down
Loading
Loading