Skip to content

Upgrade Convex environment variable configuration - #109

Open
Tyler-Petrov wants to merge 4 commits into
get-convex:mainfrom
Tyler-Petrov:t3code/upgrade-convex-env-config
Open

Upgrade Convex environment variable configuration#109
Tyler-Petrov wants to merge 4 commits into
get-convex:mainfrom
Tyler-Petrov:t3code/upgrade-convex-env-config

Conversation

@Tyler-Petrov

Copy link
Copy Markdown
  • Upgrade Convex peer dependency to ^1.39.0
  • Pass typed environment variables into Resend configuration
  • Document the new environment configuration workflow

This PR implements Convex's new env variable handling into the Resend component. This change isn't exactly backwards compatible, so I'm not sure what the process is there (maybe a new major release like PostHog). The implementation is super simple and straight forward.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Upgrade Convex peer dependency to ^1.39.0
- Pass typed environment variables into Resend configuration
- Document the new environment configuration workflow
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Tyler-Petrov, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 35 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository: get-convex/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f57bcf6-538f-42d1-af80-1d67eba86bf3

📥 Commits

Reviewing files that changed from the base of the PR and between 2514e1a and 6a6b664.

📒 Files selected for processing (1)
  • README.md
📝 Walkthrough

Walkthrough

The Resend client now requires an explicit apiKey and no longer reads environment-variable defaults internally. The example Convex app defines typed RESEND_API_KEY and optional RESEND_WEBHOOK_SECRET values, and documentation and example code pass them through env. The Convex peer dependency requirement is updated to ^1.39.0.

Possibly related PRs

  • get-convex/resend#60: Updates the manual email flow and Resend SDK setup using Convex environment values.

Suggested reviewers: ianmacartney

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adopting Convex environment variable configuration.
Description check ✅ Passed The description matches the changeset, covering the peer dependency upgrade, typed env wiring, and documentation updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@README.md`:
- Around line 33-48: Add a conditional setup instruction near the RESEND_API_KEY
configuration explaining that users enabling webhook flows must also set
RESEND_WEBHOOK_SECRET to the Resend webhook signing secret; keep it optional for
users who do not use webhooks.
- Around line 142-143: Update the webhook example’s import from
`@convex-dev/resend` to include vOnEmailEventArgs alongside the existing symbols,
so the usage in the webhook handler resolves correctly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: get-convex/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e8adf2a9-a925-4217-8f4c-f3a593a25d8b

📥 Commits

Reviewing files that changed from the base of the PR and between 2f6a91d and 2514e1a.

⛔ Files ignored due to path filters (3)
  • example/convex/_generated/server.d.ts is excluded by !**/_generated/**
  • example/convex/_generated/server.js is excluded by !**/_generated/**
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (5)
  • README.md
  • example/convex/convex.config.ts
  • example/convex/example.ts
  • package.json
  • src/client/index.ts

Comment thread README.md
Comment thread README.md Outdated
- Update the setup examples for Convex typed environment variables
- Explain configuring and using RESEND_WEBHOOK_SECRET
- Show how to set RESEND_API_KEY with the Convex CLI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant