Skip to content

Type the email event mutation argument - #111

Open
Tyler-Petrov wants to merge 1 commit into
get-convex:mainfrom
Tyler-Petrov:t3code/cee21777
Open

Type the email event mutation argument#111
Tyler-Petrov wants to merge 1 commit into
get-convex:mainfrom
Tyler-Petrov:t3code/cee21777

Conversation

@Tyler-Petrov

@Tyler-Petrov Tyler-Petrov commented Jul 30, 2026

Copy link
Copy Markdown

This PR adds a type cast for the event parameter of the handleEmailEvent mutation. It doesn't change the runtime at all just the type of the event param.

- Cast the Convex `v.any()` validator to `VAny<EmailEvent>`
- Align the test mutation call with the typed event argument
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The email webhook mutation now declares its event argument as VAny<EmailEvent> rather than an untyped value. The test helper’s mutation call explicitly casts its event payload to EmailEvent. The runtime execution flow remains unchanged.

Suggested reviewers: ianmacartney, sethconvex

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: typing the email event mutation argument.
Description check ✅ Passed The description matches the change and accurately says it only affects typing, not runtime behavior.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant