style(frontend): remove card shadows and unify card grid spacing#2154
style(frontend): remove card shadows and unify card grid spacing#2154stackingsaunter wants to merge 4 commits intogetAlby:masterfrom
Conversation
- Use shadow-none on shadcn Card and drop shadow-xs on UpgradeCard - Standardize spacing between card groups to gap-3 (12px) across grids Made-with: Cursor
Select Xcode.app before CGO so Wails WebKit uses the full SDK (avoids Foundation parsed as C on CLT-only toolchains). Skip Apple signing/notarize/DMG when the PR head is a fork; upload an unsigned zip instead. Add fail-fast: false to the HTTP build matrix. Made-with: Cursor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughConsistent Tailwind spacing adjustments across many frontend components (standardizing to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
.github/workflows/http.yml (1)
136-143:⚠️ Potential issue | 🟠 Major
build-releaseis now ignored for called macOS builds.On
workflow_call, the new predicates on Line 137 and Line 174 are always true, so the workflow still imports certs and codesigns when callers passbuild-release: false. Line 198 still respects the input, so non-release calls now produce a partially release-processed artifact instead of a plain dev build.Suggested fix
- if: runner.os == 'macOS' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false) + if: runner.os == 'macOS' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false) && (github.event_name != 'workflow_call' || inputs.build-release)Use the same predicate on both the certificate import and codesign steps.
Also applies to: 173-181
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/http.yml around lines 136 - 143, The "Import Code-Signing Certificates for macOS" step (and the corresponding codesign step) uses a predicate that always evaluates true for workflow_call callers, so it ignores the inputs.build-release flag; update the if condition on the "Import Code-Signing Certificates for macOS" step and the macOS codesign step to include the release input check (e.g., append && inputs.build-release == 'true'), ensuring both steps only run when runner.os == 'macOS' AND the caller requested build-release..github/workflows/wails.yml (1)
137-145:⚠️ Potential issue | 🟠 MajorKeep
build-releasein the macOS release predicates.
workflow_callsetsgithub.event_nametoworkflow_call, so the new checks on Line 138, Line 199, Line 209, Line 225, Line 239, and Line 266 all evaluate true even when a caller passesbuild-release: false. That makes the input ineffective and forces signing, DMG creation, notarization, and signed-artifact upload for non-release calls.Suggested fix
- if: runner.os == 'macOS' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false) + if: runner.os == 'macOS' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false) && (github.event_name != 'workflow_call' || inputs.build-release)Apply the same predicate to every release-only macOS step, including the signed artifact upload, so non-release
workflow_callbuilds stay on the unsigned path.Also applies to: 198-209, 224-239, 265-271
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/wails.yml around lines 137 - 145, Update each macOS "release-only" step (e.g., the step named "Import Code-Signing Certificates for macOS" and the macOS DMG/notarize/signed-artifact upload steps) to add a predicate that respects the reusable-workflow input so non-release workflow_call invocations stay unsigned; specifically, extend the existing if condition to require the release input when event_name == "workflow_call" (for example: keep the existing runner.os == 'macOS' check AND require that either the event is not workflow_call or inputs.build-release == 'true', while preserving the existing pull_request/fork logic).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/http.yml:
- Around line 136-143: The "Import Code-Signing Certificates for macOS" step
(and the corresponding codesign step) uses a predicate that always evaluates
true for workflow_call callers, so it ignores the inputs.build-release flag;
update the if condition on the "Import Code-Signing Certificates for macOS" step
and the macOS codesign step to include the release input check (e.g., append &&
inputs.build-release == 'true'), ensuring both steps only run when runner.os ==
'macOS' AND the caller requested build-release.
In @.github/workflows/wails.yml:
- Around line 137-145: Update each macOS "release-only" step (e.g., the step
named "Import Code-Signing Certificates for macOS" and the macOS
DMG/notarize/signed-artifact upload steps) to add a predicate that respects the
reusable-workflow input so non-release workflow_call invocations stay unsigned;
specifically, extend the existing if condition to require the release input when
event_name == "workflow_call" (for example: keep the existing runner.os ==
'macOS' check AND require that either the event is not workflow_call or
inputs.build-release == 'true', while preserving the existing pull_request/fork
logic).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9ca146f0-113f-44f0-8d5e-67d6d800f6e7
📒 Files selected for processing (2)
.github/workflows/http.yml.github/workflows/wails.yml
Gate cert import, codesign, DMG, notarize, and signed DMG upload on inputs.build-release when the event is workflow_call. Keeps fork PR unsigned zip path; push and internal PR behavior unchanged. Made-with: Cursor
Revert CI changes that attempted to fix macOS build failures; keep PRs focused on frontend changes. Made-with: Cursor
1 participant
Summary
Cardcomponent (shadow-sm→shadow-none) and fromUpgradeCard.gap-3(12px) across grids that lay out multiple cards (home, apps, sub-wallets, setup, etc.).Notes
Cardsection spacing (header/content) is unchanged.Made with Cursor
Summary by CodeRabbit
Style
Chores