fix(dash): one-shot rate showed 10000% in Model efficiency - #958
Merged
Conversation
…dy a percent The payload's current.oneShotRate is a fraction but modelEfficiency[].oneShotRate is 0-100 (the TUI and menubar render it verbatim); the dash multiplied the latter by 100 again and showed 10000% / 8570% in the Model efficiency table. Caught live during the release surface sweep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught during the v0.9.20 browser surface sweep: the payload's modelEfficiency[].oneShotRate is already a percent (0-100) - the TUI and menubar render it verbatim - but the dash multiplied by 100 again, showing 10000% / 8570% / 9380% in the Model efficiency table. current.oneShotRate (a fraction) keeps its existing correct handling in the overview card. One line plus the unit comment; dash typecheck and vite build clean; verified fixed in the live browser.