fix(release): use draft releases to prevent binary race condition#2347
Merged
dividedmind merged 1 commit intomainfrom Feb 10, 2026
Merged
fix(release): use draft releases to prevent binary race condition#2347dividedmind merged 1 commit intomainfrom
dividedmind merged 1 commit intomainfrom
Conversation
Clients querying the GitHub API could see releases before native binaries were attached, leading to potential download failures. Changes: - Create draft releases for @appland/appmap and @appland/scanner - Publish drafts after all native binaries are uploaded - Skip GitHub releases entirely for packages without native binaries
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a race condition where GitHub API clients could see releases before native binaries were attached, potentially causing download failures. The solution creates draft releases for packages with native binaries and publishes them only after all binaries are uploaded.
Changes:
- Modified semantic-release configuration to conditionally create draft GitHub releases only for packages with native binaries (@appland/appmap and @appland/scanner)
- Added workflow steps to publish draft releases after all native binaries are uploaded
- Packages without native binaries now skip GitHub releases entirely and only create git tags
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.releaserc.js |
Refactored to conditionally add GitHub plugin with draft release option only for packages with native binaries; other packages skip GitHub releases |
.github/workflows/build-native.yml |
Added step to publish draft release after all binaries are uploaded and npm package is tagged |
.github/workflows/build-native-scanner.yml |
Added step to publish draft release after all binaries are uploaded and npm package is tagged |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients querying the GitHub API could see releases before native binaries were attached, leading to potential download failures.
Changes: