fix: reject client_secret without client_id to prevent wrong-tenant data#135
Merged
saurabhjain1592 merged 3 commits intomainfrom Apr 5, 2026
Merged
fix: reject client_secret without client_id to prevent wrong-tenant data#135saurabhjain1592 merged 3 commits intomainfrom
saurabhjain1592 merged 3 commits intomainfrom
Conversation
If client_secret (license key) is set without client_id, the SDK would silently use 'community' as the tenant identity. All data would be stored under the wrong tenant, causing data loss on upgrade when client_id is eventually set correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject
client_secret/clientSecretwhenclient_id/clientIdis not set. Without this check, the SDK silently usescommunityas the tenant identity, causing all licensed data to be stored under the wrong tenant.Three valid configurations:
clientId=community, no license)clientIdonly → community mode with custom tenantAligns with getaxonflow/axonflow-enterprise#1492 unified identity model.
Test plan
client_secretwithoutclient_idthrows clear errorclient_idwithoutclient_secretworks (community with custom tenant)