Wallet: move database to sqlite, remove kv and memmory db by jaoleal · Pull Request #804 · getfloresta/Floresta

jaoleal · 2026-01-24T21:13:02Z

Description and Notes

Addressing #665, I implemented the existing AddressCacheDatabase trait on top of rusqlite, the only feature that the changes present is "bundled" which they declared to be better when regarding windows support.

Regarding the implementation, it is pretty straightforward, I had the other two databases, memmory_database.rs and kv_database.rs to be inspired. I think the tests are extensive and ensure the implementation runs fine, for every commit I made sure for just lint-features and just test-feature to also run fine.

How to verify the changes you have done?

Review tests under sqlite_database.rs and run them.

Since this present a lot of features changes, running just lint-features and just test-feature is good.

Contributor Checklist

I've followed the contribution guidelines
[] I've verified one of the following:
- Ran just pcc (recommended but slower)
- Ran just lint-features '-- -D warnings' && cargo test --release
- Confirmed CI passed on my fork
I've linked any related issue(s) in the sections above

Finally, you are encouraged to sign all your commits (it proves authorship and guards against tampering—see How (and why) to sign Git commits and GitHub's guide to signing commits).

crates/floresta-watch-only/src/sqlite_database.rs

jaoleal · 2026-01-24T22:18:22Z

a5e86c3: Im seeing some build related problems, it appears that "bundled" isnt enough, ill investigate further.

jaoleal · 2026-01-25T00:37:51Z

37e383c: Okay, this commit fixed the build problem i was having.

Basically what happened is that they were bundling pre-generated bindings and that was triggering a version compatibility problem basicaly because rust doesnt want to have a stable ABI, it can change trough versions affecting bindings and yada yada.

They took that decision to avoid bigger compile times but that doesnt appear to be a big problem, well... To solve that i activated the feature that should generate the bindings on the go and it worked, otherwise i would need to find a rusqlite version that was bundling the correct bindings for our MSRV and pin it, and im not sure if that would support our case.

If anyone want to further investigate to help me being sure that was the correct decision:

Davidson-Souza

Generally looks good. Minor comments

I think a5e86c3 and 37e383c can be squashed onto 9cbc9f1.

crates/floresta-watch-only/Cargo.toml

crates/floresta-watch-only/src/sqlite_database.rs

crates/floresta-watch-only/Cargo.toml

jaoleal · 2026-01-28T12:54:49Z

Notable changes on 57695dc

Rebased
No more json cast, removed serde_json.
Tables now looks more like the types we are storing, fields with rust-bitcoin types I used the Blob type with the consensus encoding, fields with primitives I mapped to equivalent SQL primitives.
Removed all unwraps(where possible), better error handling in general.
Cast to types internally on maps to save iterations.

crates/floresta-watch-only/src/sqlite_database.rs

jaoleal · 2026-01-29T11:59:41Z

Done @Davidson-Souza @luisschwab

Davidson-Souza

Your commits are in reverse chronological order. What happened?

Davidson-Souza · 2026-01-29T16:28:58Z

crates/floresta-watch-only/src/lib.rs

-        self.database.save(&new_address);
+        self.database
+            .save(&new_address)
+            .expect("Database not working");


Errors that can happens should either be handled or propagated

again, that refers to another method that does not return a result and IMHO changing this method would be out-of-scope for this pr.

I don't think it's out of scope, but I would recommend opening another pr before this one gets merged, improving this trait to return a result. Since you are touching this, I think it's better to do it right. The old method was infallible because it had an expect inside the DB wrapper, completely terrible!

crates/floresta-watch-only/src/sqlite_database.rs

jaoleal · 2026-02-02T18:53:30Z

Your commits are in reverse chronological order. What happened?

Yeah, i reversed the commits because its easier to apply suggestions on the latest commit instead of the first... The old order was erroring while editing the first commit because of feature flags and deprecation changes

jaoleal · 2026-02-02T22:48:17Z

Applied @Davidson-Souza suggestions

jaoleal · 2026-02-02T23:35:36Z

Blank push -f, for some reason the CI just DIED

JoseSK999 · 2026-02-03T21:55:23Z

It's rebase season

crates/floresta/examples/watch-only.rs

crates/floresta-watch-only/src/sqlite_database.rs

jaoleal · 2026-03-02T20:21:09Z

Rebased and Applied @JoseSK999 suggestions.

crates/floresta-electrum/Cargo.toml

JoseSK999 · 2026-03-08T17:28:44Z

@jaoleal needs rebase and fix my comment, after that I think this is ready

JoseSK999 · 2026-03-10T16:30:09Z

crates/floresta-node/src/error.rs

+);

-impl error::Error for FlorestadError {}
+impl std::error::Error for FlorestadError {}


Revert this, we should use the imported error path, this was one of those refactor issues

jaoleal · 2026-03-10T17:24:35Z

Done! @JoseSK999

jaoleal · 2026-03-16T20:22:31Z

Done, rebased with master

moisesPompilio · 2026-03-17T20:55:16Z

Need rebase

Replace panicking .expect() and .unwrap() calls in AddressCacheInner and AddressCache methods with proper error propagation.

jaoleal · 2026-03-19T16:12:53Z

Rebased

GustavoStingelin reviewed Jan 24, 2026

View reviewed changes

crates/floresta-watch-only/src/sqlite_database.rs Show resolved Hide resolved

Davidson-Souza added dependencies Pull requests that update a dependency file code quality Generally improves code readability and maintainability labels Jan 24, 2026

jaoleal force-pushed the wallet_sqlite_descbased branch from 90f9da2 to a5e86c3 Compare January 24, 2026 22:11

jaoleal force-pushed the wallet_sqlite_descbased branch from ba07354 to 14231f8 Compare January 25, 2026 00:12

Davidson-Souza requested changes Jan 26, 2026

View reviewed changes

Davidson-Souza reviewed Jan 26, 2026

View reviewed changes

crates/floresta-watch-only/Cargo.toml Outdated Show resolved Hide resolved

jaoleal force-pushed the wallet_sqlite_descbased branch 2 times, most recently from 6f0f109 to 05134fe Compare January 28, 2026 12:50

jaoleal force-pushed the wallet_sqlite_descbased branch 2 times, most recently from 4252dbd to 090fe9d Compare January 28, 2026 13:35

luisschwab reviewed Jan 28, 2026

View reviewed changes

crates/floresta-watch-only/src/sqlite_database.rs Show resolved Hide resolved

luisschwab assigned jaoleal Jan 28, 2026

jaoleal force-pushed the wallet_sqlite_descbased branch 2 times, most recently from c8199b4 to 47bd5c7 Compare January 28, 2026 22:43

Davidson-Souza requested changes Jan 29, 2026

View reviewed changes

jaoleal closed this Feb 2, 2026

jaoleal reopened this Feb 2, 2026

jaoleal force-pushed the wallet_sqlite_descbased branch from 47bd5c7 to cfaa2ab Compare February 2, 2026 22:47

jaoleal force-pushed the wallet_sqlite_descbased branch from cfaa2ab to e358b7f Compare February 2, 2026 23:35

jaoleal force-pushed the wallet_sqlite_descbased branch 2 times, most recently from a76a391 to a874519 Compare February 4, 2026 15:00

moisesPompilio mentioned this pull request Feb 23, 2026

[Enhancement] Add DB migrations for SQLite #856

Open

jaoleal requested review from Davidson-Souza, JoseSK999, luisschwab and moisesPompilio February 24, 2026 17:02

jaoleal mentioned this pull request Feb 24, 2026

rpcserver: Support named and null parameters, Review optionals on rpc internal methods, Stronger Response and Error codes #831

Open

3 tasks

JoseSK999 reviewed Feb 25, 2026

View reviewed changes

jaoleal force-pushed the wallet_sqlite_descbased branch from d8bef82 to ccbb10d Compare March 2, 2026 20:21

JoseSK999 reviewed Mar 5, 2026

View reviewed changes

crates/floresta-electrum/Cargo.toml Outdated Show resolved Hide resolved

jaoleal force-pushed the wallet_sqlite_descbased branch 2 times, most recently from 321823a to 1252659 Compare March 9, 2026 15:21

JoseSK999 reviewed Mar 10, 2026

View reviewed changes

Davidson-Souza removed this from the v0.9.0 milestone Mar 10, 2026

jaoleal force-pushed the wallet_sqlite_descbased branch from 1252659 to bb716d5 Compare March 10, 2026 17:21

jaoleal force-pushed the wallet_sqlite_descbased branch 4 times, most recently from cb490f4 to a630d33 Compare March 16, 2026 20:22

jaoleal added 4 commits March 18, 2026 03:17

chore(wallet): deprecate kv database

5a809ba

chore(wallet): deprecate memory database

6c2608e

feat(wallet): SQLite database.

ccae5c9

refactor(wallet): replace expects/unwraps with proper error propagation

c5e692b

Replace panicking .expect() and .unwrap() calls in AddressCacheInner and AddressCache methods with proper error propagation.

jaoleal force-pushed the wallet_sqlite_descbased branch from a630d33 to c5e692b Compare March 18, 2026 06:19

jaoleal added the Wallet Changes related to the watch-only wallet label Mar 27, 2026

Conversation

jaoleal commented Jan 24, 2026

Description and Notes

How to verify the changes you have done?

Contributor Checklist

Uh oh!

Uh oh!

jaoleal commented Jan 24, 2026

Uh oh!

jaoleal commented Jan 25, 2026

Uh oh!

Davidson-Souza left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaoleal commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jaoleal commented Jan 29, 2026

Uh oh!

Davidson-Souza left a comment

Choose a reason for hiding this comment

Uh oh!

Davidson-Souza Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

jaoleal Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Davidson-Souza Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaoleal commented Feb 2, 2026

Uh oh!

jaoleal commented Feb 2, 2026

Uh oh!

jaoleal commented Feb 2, 2026

Uh oh!

JoseSK999 commented Feb 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaoleal commented Mar 2, 2026

Uh oh!

Uh oh!

JoseSK999 commented Mar 8, 2026

Uh oh!

JoseSK999 Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

jaoleal commented Mar 10, 2026

Uh oh!

jaoleal commented Mar 16, 2026

Uh oh!

moisesPompilio commented Mar 17, 2026

Uh oh!

jaoleal commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

jaoleal commented Jan 28, 2026 •

edited

Loading