Post-P-2373: stop claiming the API still accepts long-form operator aliases#21
Merged
Merged
Conversation
…liases P-2373 Phase A+B shipped to prod today and superseded the deprecated-but- accepted state: /v0/profiles (and every other filter surface) now rejects the long-form spellings (equals/notEquals/greater/greaterOrEqual/less/ lessOrEqual/notIn/includes) with a 400 naming the token. Only the 13 canonical terse tokens are accepted. The CLI's verbatim passthrough of the op token is unchanged and still correct — the server's 400 carries a clear message — but the docs and help text must no longer claim aliases work end-to-end. - README.md / SKILLS.md: FilterCondition op row — aliases are retired and rejected, not "still accepted" - src/commands/profiles.ts: --conditions help text updated the same way - test/commands/bodyBuilders.test.ts: passthrough test retitled to reflect that the server now rejects long forms (behavior under test unchanged) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
P-2373 Phase A+B (formono
71c36bf89, shipped to prod today) fully retired the filter alias-folding / dual-accept layer, superseding the state #20 documented:/v0/profilesno longer folds the long-form spellings (equals,notEquals,greater,greaterOrEqual,less,lessOrEqual,notIn,includes) to canonical — it rejects them with a400naming the token. Only the 13 canonical terse tokens (eq,neq,in,nin,gt,gte,lt,lte,contains,startsWith,endsWith,notEmpty,isEmpty) are accepted.The CLI's verbatim passthrough of the
optoken is unchanged and still the right behavior — the server's400carries a clear message — but every claim that the aliases "still work end-to-end" is now false.Changes (docs/help text only, no behavior change)
oprow: aliases are retired and rejected with a400, not "deprecated aliases the API still accepts".--conditionshelp text updated the same way.Verification
pnpm build(tsc): clean.pnpm lint(eslint): clean.pnpm test(mocha): 123 passing, 20 pending (pre-existing placeholders, untouched).🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.