Post-P-2373: legacy filter-operator spellings are rejected, not accepted#115
Merged
Conversation
P-2373 Phase A+B shipped to prod today and superseded the earlier "deprecated but accepted aliases" state: the long-form spellings (equals/notEquals/greater/greaterOrEqual/less/lessOrEqual/notIn/includes), symbol forms, and 'like' are now rejected with a 400 naming the token on every filter surface. Only the 13 canonical terse tokens are accepted. - api/openapi.json: sync with the shipped backend spec (FilterCondition enum canonical-only; alias-acceptance wording removed from all five op-enum sites; funnel/flow examples use canonical tokens) - api/profiles/search.mdx: aliases are retired + 400, not "folded" - api/boards/create-chart.mdx: numeric long forms rejected, not accepted (x2) - api/query/funnel.mdx: operator list now the canonical dialect (eq/neq/nin/contains); example uses "eq"; long forms documented as rejected - api/query/flow.mdx: in/nin (not notIn); canonical-only note - cli/profiles.mdx: long forms rejected by the API, not "still accepted" Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
P-2373 Phase A+B (formono
71c36bf89, shipped to prod today) fully retired the filter alias-folding / dual-accept layer. This supersedes the state these docs were written against (#114), where the long-form spellings were "deprecated but still accepted / folded at the input boundary". As of today:eq,neq,in,nin,gt,gte,lt,lte,contains,startsWith,endsWith,notEmpty,isEmpty./v0/profilesand the funnel/flow/chart/alert filter surfaces rejectequals/notEquals/greater/greaterOrEqual/less/lessOrEqual/notIn/includes(andlike/symbol forms) with a400naming the token.FilterConditionno longer lists the aliases).Changes
apps/backend/src/openapi.jsonat prod HEAD): FilterCondition enum drops the 8 alias entries; alias-acceptance wording removed from all five op descriptions; funnel/flow/segments examples use canonical tokens.400naming the token.400.equals/notEquals/notIn/includes) with "long forms accepted as equivalents"; now the canonical dialect (eq/neq/nin/contains), curl example uses"operator":"eq", and the pipe-delimitedin/ninvalue note matches the shipped spec.notIn→nin; canonical-only note added.400.Verification
python3semantic JSON compare ofapi/openapi.jsonvs formonoapps/backend/src/openapi.json: identical.npx mintlify validate: build validation passed.mintlify broken-links: none.--name/--status paused).🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.