Skip to content

P-2208: Harden github actions - #19

Merged
yosriady merged 1 commit into
mainfrom
keilok/harden-github-actions
May 21, 2026
Merged

P-2208: Harden github actions#19
yosriady merged 1 commit into
mainfrom
keilok/harden-github-actions

Conversation

@keiloktql

@keiloktql keiloktql commented May 20, 2026

Copy link
Copy Markdown
Contributor
  • Created dependabot.yml (matching sibling SDK repos) with 7-day cooldown on github-actions + npm ecosystems
  • ci.yml: persist-credentials: false on all 3 checkouts
  • release.yml: persist-credentials: false; drop pnpm cache from setup-node (cache-poisoning mitigation); quote variable to fix SC2086
  • Verified pnpm/action-setup explicit version: 11

Refs P-2208.


View in Codesmith
Need help on this PR? Tag @codesmith with what you need.

  • Let Codesmith autofix CI failures and bot reviews

- Created dependabot.yml (matching sibling SDK repos) with 7-day
  cooldown on github-actions + npm ecosystems
- ci.yml: persist-credentials: false on all 3 checkouts
- release.yml: persist-credentials: false; drop pnpm cache from
  setup-node (cache-poisoning mitigation); quote variable to fix SC2086
- Verified pnpm/action-setup explicit version: 11

Refs P-2208.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@keiloktql
keiloktql requested a review from yosriady May 20, 2026 09:57
@keiloktql keiloktql self-assigned this May 20, 2026
@linear-code

linear-code Bot commented May 20, 2026

Copy link
Copy Markdown

P-2208

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a .github/dependabot.yml configuration file to automate dependency updates for GitHub Actions and npm. Review feedback identifies that the cooldown property used in both update configurations is not a supported key in the official Dependabot schema, which may lead to an invalid configuration. It is recommended to remove these keys or use supported features like update grouping to manage the frequency of pull requests.

Comment thread .github/dependabot.yml
Comment on lines +12 to +13
cooldown:
default-days: 7

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The cooldown property is not a supported configuration option for GitHub Dependabot. Including unknown keys in dependabot.yml may cause the configuration to be flagged as invalid or ignored in the repository's 'Dependency graph' settings. If the intention is to throttle updates or reduce noise, consider using the groups feature to bundle updates or adjusting the schedule.interval.

Comment thread .github/dependabot.yml
Comment on lines +24 to +25
cooldown:
default-days: 7

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The cooldown property is not recognized by GitHub Dependabot. While pnpm 11 supports minimumReleaseAge in pnpm-workspace.yaml (which is correctly configured in this repository), Dependabot does not have a corresponding configuration key. This block should be removed to ensure the configuration adheres to the official schema and functions as expected.

@yosriady
yosriady merged commit 3b1141a into main May 21, 2026
9 checks passed
@yosriady
yosriady deleted the keilok/harden-github-actions branch May 21, 2026 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants