fix(ci): unpin Node/npm engine mismatch breaking publish#57
Merged
Conversation
`npm install -g npm@latest` began resolving to npm 12.0.1, whose engines require Node ^22.22.2 || ^24.15.0 || >=26.0.0. The release workflow pins Node 22.14.0, so the step failed with EBADENGINE and the v1.0.0 publish never ran. Nothing in the repo changed -- npm 12 shipped and moved the floor under a floating dist-tag. Bump Node to 22.23.1 (current v22 LTS patch, satisfies ^22.22.2) and pin npm to the major (npm@12) so the next npm major cannot silently break releases again. The step exists only because Node 22 bundles npm 10.9.x, which predates the OIDC trusted publishing support added in 11.5.1. Node is bumped in ci.yml too, since CI and release are deliberately kept on the same pin and drift between them is its own hazard. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm install -g npm@latestbegan resolving to npm 12.0.1, whose engines require Node ^22.22.2 || ^24.15.0 || >=26.0.0. The release workflow pins Node 22.14.0, so the step failed with EBADENGINE and the v1.0.0 publish never ran. Nothing in the repo changed -- npm 12 shipped and moved the floor under a floating dist-tag.Bump Node to 22.23.1 (current v22 LTS patch, satisfies ^22.22.2) and pin npm to the major (npm@12) so the next npm major cannot silently break releases again. The step exists only because Node 22 bundles npm 10.9.x, which predates the OIDC trusted publishing support added in 11.5.1.
Node is bumped in ci.yml too, since CI and release are deliberately kept on the same pin and drift between them is its own hazard.
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.